Allow building against external zstd library (for non-CMake builds) #344
Conversation
|
I would also like to see this (or something similar to this) merged. @richgel999 |
|
so do I, for the Debian package! for the impatient: http://sid.ethz.ch/debian/basis-universal/ |
|
@akien-mga Looks like the latest commits to master have yielded some small conflicts, but hopefully @richgel999 might be willing to take a look at this once resolved? |
akien-mga
force-pushed
the
zstd-external
branch
from
b4a0fa2 to
6394a27
Compare
|
Rebased on latest |
…ns (mostly in non CMake builds). In our internal repository, we have our own version of zstdlib and introducing extra copy is both undesirable and potentially dangerous (due to ODR violations). Co-authored-by: Rémi Verschelde <[email protected]>
akien-mga
force-pushed
the
zstd-external
branch
from
6394a27 to
19d6c6c
Compare
|
Rebased to get AppVeyor CI to pass, the previous commit failed due to a random connectivity error. |
|
@richgel999 Just wanted to bump this - would be great to be able to get something like this merged! |
|
I'd like to see this merged too, I have to make the same changes for my build. |
|
@richgel999 Just a gentle reminder of this PR, and a kind request to please consider merging it. (Wanting to use zstd as well as basis_universal in the same project is an ever-more-common case.) |
5 participants
Rebase of @ondys' #228 with one missed include changed too.
Supersedes #228. (This PR can be closed if #228 is updated with the
transcoderchange.)We have the same need in the Godot project, also with a non-CMake build (relevant build file for SCons: https://github.com/godotengine/godot/blob/master/modules/basis_universal/SCsub).
CMake users may also want to have an easy way to use their own zstd implementation, but for this PR I followed @ondys' steps to do the minimal changes needed by existing downstream projects which shouldn't break the workflow for the main app.