refactor PMacc event system #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Is this line intentionally commented out?
There was a problem hiding this comment.
right this should in, might be this is my bug what I searched for
- use plain old pointers linke in the original code - make `CudaEvent` copyable
psychocoderHPC
force-pushed
the
picongpu-alpaka-dev_changeEventSystem
branch
from
2d75a74 to
bfbb1bb
Compare
|
updated but with valgrind we get a warning in PMacc event system (EventStream.hpp:70 some warning like in the base branch of this pull request) |
BenjaminW3
force-pushed
the
alpaka
branch
13 times, most recently
from
57302cb to
71ecd42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CudaEventcopyable