DRAFT: BATS: unofficial strict mode #2032
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This branch adds
set -Eeuo pipefail
to the bottom ofsetup()
, so each test is run with extremely strict environment.Motivation and Context
Hence Chapter 4. This will help to prevent regressions, as well as catch omissions that
shellcheck
misses (like unbound positional parameters).How Has This Been Tested?
This is built in top of my
precommit
branch (#2033), so the*.bats
tests themselves are already fairly tight, so this PR is just for actually applying the strictness to the main code.Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.