Consolidate preexec-related functions; Eliminate vendor/init.d
#2003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
preexec
branch
from
3a81daa to
2e50345
Compare
gaelicWizard
changed the title
vendor/init.dvendor/init.d; consolidate preexec functions
gaelicWizard
force-pushed
the
preexec
branch
from
2e50345 to
991f39a
Compare
gaelicWizard
changed the title
vendor/init.d; consolidate preexec functionspreexec-related functions; Eliminate vendor/init.d
gaelicWizard
force-pushed
the
preexec
branch
from
991f39a to
190bd87
Compare
6 tasks
NoahGorny
requested changes
Jan 3, 2022
6 tasks
|
Rebased on current master and ready to go! |
gaelicWizard
force-pushed
the
preexec
branch
3 times, most recently
from
4e7a985 to
16e1719
Compare
|
Rebased on current master and ready to go! |
gaelicWizard
force-pushed
the
preexec
branch
3 times, most recently
from
9a89ae3 to
d68f334
Compare
|
Rebased on current master and ready to go! |
NoahGorny
approved these changes
Jan 25, 2022
Define the helper functions for `bash-preexec.sh` immediately after importing it, rather than in `lib/theme`. - `__check_precmd_conflict()` and `save_append_prompt_command()` are generally useful and not theme-specific. - Add matching `__check_preexec_conflict()` and `safe_append_preexec()`.
Alsö, use `_bash-it-array-contains-element()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see individual commit messages as needed.
Description
The
vendor/init.dfolder had only one file in it,preexec.bash, and may have been created in a fit of premature optimization. Lose it!Closes #1844.
Motivation and Context
There's useful functions related to preexec that ought to be in the file, and a few more are needed, and none are usable until after it's loaded.
This PR:
preexec.bashtolib,bash_it.sh,lib/themetolib/preexec,How Has This Been Tested?
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.