Skip to content

fix: (Throws FormatException: Unexpected end of input (at character 1)) - check a file has content before process #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: (Throws FormatException: Unexpected end of input (at character 1)) - check a file has content before process #497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ter_cache_manager/lib/src/storage/cache_info_repositories/json_cache_info_repository.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ class JsonCacheInfoRepository extends CacheInfoRepository
Future<void> _readFile(File file) async {
_cacheObjects.clear();
_jsonCache.clear();
if (await file.exists()) {
final hasContent = await file.length() > 0;
if (await file.exists() && hasContent) {
try {
final jsonString = await file.readAsString();
final json = jsonDecode(jsonString) as List<dynamic>;
Expand Down
20 changes: 20 additions & 0 deletions flutter_cache_manager/test/repositories/json_file_repository_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,26 @@ void main() {
});
});

test('Open repository should not report error when file is empty',
() async {
final originalOnError = FlutterError.onError;
FlutterError.onError = (FlutterErrorDetails details) {
throw details.exception;
};

final tempFile = File('${Directory.systemTemp.path}/test_empty.json');
await tempFile.create();
expect(await tempFile.length(), 0);

final repository = JsonCacheInfoRepository.withFile(tempFile);
await repository.open();

expect(await repository.getAllObjects(), isEmpty);

await tempFile.delete();
FlutterError.onError = originalOnError;
});

group('Exist and delete', () {
test('New repository does not exist', () async {
var repository = JsonCacheInfoRepository.withFile(File(path));
Expand Down