Fix multi-touch issue when a secondary pointer lifts #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to fix multi-touch issue seen on some OEM devices i.e. OPPO, where the image might pan abruptly when the user lifts a secondary pointer. This is mainly caused by using the cached pointer index from last event, which is not guaranteed to point to the same pointer across events.
|
how do i fix crash for PhotoView, i can extend ViewPager and ignore the exception but that won't change the implementation of PhotoView. Photoview makes use of default ViewPager, how am i going to change that to get it working ? |
|
Oppo phones do have this problem，This submission is valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix multi-touch issue seen on some OEM devices i.e. OPPO, where the image might pan abruptly when the user lifts a secondary pointer. This is mainly caused by using the cached pointer index from last event, which is not guaranteed to point to the same pointer across events.