Skip to content

fix: task exception was never retrieved in transcribe #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nquang29
Copy link
Collaborator

@nquang29 nquang29 requested a review from beastoin April 10, 2025 18:29
@nquang29
Copy link
Collaborator Author

nquang29 commented Apr 10, 2025

help me to review @beastoin
during testing, i found that func send_last_conversation can throw this error, so i fixed it as well:

Task exception was never retrieved future: <Task finished name='Task-8' coro=<_listen.<locals>.send_last_conversation() done,

@beastoin
Copy link
Collaborator

1/ any feasible solutions without try-catch ?

@nquang29

@nquang29 nquang29 force-pushed the 2175_except_never_retrieve branch 2 times, most recently from 992a513 to 6693365 Compare April 11, 2025 17:37
@nquang29
Copy link
Collaborator Author

1/ another way is use await sir @beastoin

@beastoin
Copy link
Collaborator

1/ wait wait, why asyncio.create_task was the issue but await is not ? you know we didn;t want users to wait for finish the sending initial file(for speaker indentificating) before using our speech to text service.

@nquang29

@nquang29 nquang29 force-pushed the 2175_except_never_retrieve branch from 6693365 to 30172a9 Compare April 14, 2025 18:31
@nquang29
Copy link
Collaborator Author

1/ >asyncio.create_task was the issue but await is not : Task exception was never retrieved appear when exception is raised in task but task never awaited or inspects on it

i created an util func to create task safely if exist exception @beastoin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants