Allow Contour Loads to be applied to specific panels and adds Combination Type to LoadCombs #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staintono
added
status:WIP
staintono
changed the title
staintono
changed the title
Chrisshort92
reviewed
Aug 4, 2025
Chrisshort92
left a comment
Chrisshort92
left a comment
There was a problem hiding this comment.
I have tested the functionality against the test script with some modifications. I separated the panels to graphically verify load was only applied to the two panels selected and not all three.
|
@peterjamesnugent can you review the code before approving? |
peterjamesnugent
requested changes
Aug 4, 2025
Member
peterjamesnugent
left a comment
peterjamesnugent
left a comment
There was a problem hiding this comment.
A few changes but otherwise looks good.
Can you make sure the change log is properly documented and the type: label is correct (i.e. feature, bug, api change) so it gets captured properly on the installer change log.
staintono
removed
the
status:WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #559
Closes #561
Adds a fragment to ContourLoad allowing for the panel numbers to be defined for contour loading.
Adds a fragment to LoadCombination to allow for the Combination Type (currently only ULS and SLS) to be defined
Test files
Test Files
Changelog
New Enum CombinationType to specify load combination types.
New Fragment LoadCombinationType added to LoadCombinations to allow combination types to be assigned.
New Fragment ContourLoadPanelNumbers added to define specific panels to which the load should be applied.
Updated Robot conversion methods to incorporate the new fragment properties.
Additional comments
AI (Github CoPilot) used to assist with the architecture of methods, writing first drafts and debugging.