Skip to content

Conversation

mohitc1
Copy link
Contributor

@mohitc1 mohitc1 commented Sep 8, 2025

proguard rules

update consumer rrules
Copy link

github-actions bot commented Sep 8, 2025

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copy link

github-actions bot commented Sep 8, 2025

✅ Work item link check complete. Description contains link AB#3340920 to an Azure Boards work item.

@github-actions github-actions bot changed the title update rules update rules, Fixes AB#3340920 Sep 8, 2025
@mohitc1 mohitc1 marked this pull request as ready for review September 8, 2025 16:00
@Copilot Copilot AI review requested due to automatic review settings September 8, 2025 16:00
@mohitc1 mohitc1 requested review from a team as code owners September 8, 2025 16:00
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates ProGuard rules to fix build issues by adding new -dontwarn directives and modifying existing keep rules. The changes resolve compilation warnings related to Google Crypto Tink and BouncyCastle dependencies.

  • Added -dontwarn rules for Google Crypto Tink and BouncyCastle classes to suppress warnings
  • Modified ProGuard keep rules to remove exclusions and obfuscation allowance
  • Updated common submodule reference

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
testapps/testapp/proguard-rules.pro Added -dontwarn directives for crypto libraries
msal/consumer-rules.pro Removed class exclusions and obfuscation allowance from keep rules
common Updated submodule commit reference
changelog Added entry documenting the ProGuard rules update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mohitc1 mohitc1 changed the title update rules, Fixes AB#3340920 [MSAL] Update proguard rules, Fixes AB#3340920 Sep 8, 2025
@mohitc1 mohitc1 merged commit 8a8c96e into dev Sep 16, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants