-
Notifications
You must be signed in to change notification settings - Fork 137
[MSAL] Update proguard rules, Fixes AB#3340920 #2372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
proguard rules update consumer rrules
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
✅ Work item link check complete. Description contains link AB#3340920 to an Azure Boards work item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates ProGuard rules to fix build issues by adding new -dontwarn directives and modifying existing keep rules. The changes resolve compilation warnings related to Google Crypto Tink and BouncyCastle dependencies.
- Added -dontwarn rules for Google Crypto Tink and BouncyCastle classes to suppress warnings
- Modified ProGuard keep rules to remove exclusions and obfuscation allowance
- Updated common submodule reference
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
testapps/testapp/proguard-rules.pro | Added -dontwarn directives for crypto libraries |
msal/consumer-rules.pro | Removed class exclusions and obfuscation allowance from keep rules |
common | Updated submodule commit reference |
changelog | Added entry documenting the ProGuard rules update |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Fixes AB#3340920
Common: AzureAD/microsoft-authentication-library-common-for-android#2756
RUn: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1532428&view=results