Skip to content

Conversation

@devanshjainms
Copy link
Contributor

This pull request mainly focuses on cleaning up unused imports and minor code simplifications across both implementation and test files, as well as removing some redundant variables and debugging statements. These changes help make the codebase more maintainable and easier to read.

Code cleanup and simplification

  • Removed unused imports such as ipaddress, ABC, abstractmethod, re, shlex, and logging from src/module_utils/collector.py and src/module_utils/filesystem_collector.py to reduce clutter and improve clarity. [1] [2]
  • Removed unnecessary imports (unittest.mock, logging, etc.) from several test files to streamline dependencies and encourage the use of pytest for mocking. [1] [2] [3]

Minor logic and test adjustments

  • Removed the unused lv_size variable from the LVM details extraction logic in gather_all_filesystem_info for better code clarity.
  • Simplified assertions and removed redundant variable assignments in tests, such as eliminating unnecessary result print statements and variable initialization. [1] [2] [3] [4]

…n collector and filesystem_collector modules; enhance tests by removing unnecessary assertions and print statements.
@devanshjainms devanshjainms requested a review from a team as a code owner October 29, 2025 00:07
@devanshjainms devanshjainms requested review from Copilot and mkdeegan and removed request for Copilot October 29, 2025 00:07
Copy link
Member

@hdamecharla hdamecharla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@devanshjainms devanshjainms merged commit ed57a10 into Azure:development-oct-2025 Oct 29, 2025
6 checks passed
@devanshjainms devanshjainms deleted the pr-updates branch October 29, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants