Enhance AzureDataParser to support additional mount point formats #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… update playbook loops to ensure unique host entries for configuration checks
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the SAP Testing Automation Framework's configuration validation by preventing duplicate host processing and improving disk mount point detection. The changes ensure more accurate system configuration checks and better report traceability.
Key changes:
- Deduplicated host groups across all configuration check loops using the
uniquefilter - Enhanced disk parsing to recognize SAP-specific subdirectory mount points (e.g.,
/hana/data/SID) - Improved report file naming with
test_group_invocation_idfor better traceability
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/playbook_00_configuration_checks.yml | Applied unique filter to all host group loops and enhanced report filename with invocation ID |
| src/module_utils/collector.py | Extended mount point matching to include database_sid and sap_sid subdirectories |
…onfiguration checks in YAML files for improved clarity and functionality
…ure in configuration checks
…ing; update condition for ANF IP addresses in configuration checks
…ount name comparison
mkdeegan
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the accuracy and reliability of SAP system configuration checks by refining how host groups are processed and enhancing disk variable parsing. The main changes ensure that host lists are deduplicated and more robust, and that disk parsing logic correctly matches additional SAP-specific mount points.
Host group deduplication and reporting improvements:
src/playbook_00_configuration_checks.ymlto use theuniquefilter, preventing duplicate hosts from being processed in configuration and check tasks. This affects VM info, package info, common SAP, networking, ASCS/SCS, SCS HA config, application server checks, and reporting. [1] [2] [3] [4] [5] [6] [7] [8]src/playbook_00_configuration_checks.ymlto includetest_group_invocation_id, making report files easier to identify and trace.Disk variable parsing logic:
src/module_utils/collector.pyto match not only the base mount point but also SAP-specific subdirectories fordatabase_sidandsap_sid, ensuring more accurate filesystem data collection.