AFS fixes

[devanshjainms]

This pull request introduces significant improvements to the SAP configuration checks, focusing on expanding coverage for ASCS and APP roles, enhancing reporting and debugging, and improving robustness in disk and storage data collection. The changes ensure more comprehensive checks for SAP workloads, better error handling, and clearer report outputs.

Expanded SAP Checks for ASCS and APP Roles

• Added new checks for ASCS and APP roles in ascs.yml and app.yml to cover filesystem mount points, Azure disks, LVM groups/volumes, and ANF volumes, with output in table format for easier reporting. [1] [2] [3] [4]

Reporting and Output Improvements

• Updated report file naming in playbook_00_configuration_checks.yml to remove test_group_invocation_id, simplifying the report name and debug output for better clarity.

Robustness and Error Handling in Disk Collection

• Improved error handling and output in the AFS storage account metadata collection shell script in disks.yml, including checks for command failures and clearer error messages. Also, switched to using the privatelink DNS and updated quota field handling.

Expanded Disk Checks Triggering

• Modified logic in both Python (configuration_check_module.py) and Ansible (main.yml) to trigger disk checks for ASCS and APP roles in addition to HANA and DB2, ensuring these roles are included in disk-related validations. [1] [2]

Enhanced Debug Logging for HA Modules

• Added debug output for logs from HA DB, SCS, and Load Balancer modules, making troubleshooting easier by printing relevant logs only when available. [1] [2] [3]

These changes collectively improve the reliability, coverage, and usability of SAP configuration checks for Azure environments.

[hdamecharla]

Approved

[Copilot]

Pull Request Overview

This pull request enhances the SAP Testing Automation Framework's configuration checks by expanding coverage to ASCS and APP roles, improving error handling in storage data collection, and standardizing debug output across HA modules. The changes focus on making disk/storage validation more comprehensive while improving observability and reporting clarity.

Key changes:

• Extended disk/storage checks to ASCS and APP roles in addition to HANA/DB2
• Enhanced AFS storage metadata collection with better error handling and DNS configuration
• Standardized debug logging to use logs field consistently across all check types

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/roles/configuration_checks/tasks/files/ascs.yml	Added five new checks (ASCS-0002 through ASCS-0006) for filesystem, disk, LVM, and ANF validation
src/roles/configuration_checks/tasks/files/app.yml	Added five new checks (APP-0008 through APP-0012) mirroring ASCS checks for APP role
src/roles/configuration_checks/tasks/main.yml	Expanded disk check triggers to include "ascs" and "app" roles; standardized debug output to use logs field
src/roles/configuration_checks/tasks/ha_modules.yml	Added debug output for HA module logs with proper conditional checks
src/roles/configuration_checks/tasks/disks.yml	Enhanced AFS storage account collection with error handling, privatelink DNS, and corrected quota field
src/modules/configuration_check_module.py	Extended filesystem collector invocation to ASCS and APP roles
src/module_utils/filesystem_collector.py	Added storage account name matching for AFS volumes
src/playbook_00_configuration_checks.yml	Removed test_group_invocation_id from report filename; standardized pip dependencies
src/playbook_00_ha_db_functional_tests.yml	Standardized pip dependencies order
src/playbook_00_ha_scs_functional_tests.yml	Added missing pip dependencies
src/playbook_01_ha_offline_tests.yml	Standardized pip dependencies order
src/modules/get_azure_lb.py	Reformatted multi-line expression to single line
src/templates/config_checks_report.html	Increased report container max-width from 1400px to 1800px
tests/modules/get_azure_lb_test.py	Reformatted list initialization to single line