Skip to content

Config check working #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 158 commits into from
Closed

Config check working #128

wants to merge 158 commits into from

Conversation

devanshjainms
Copy link
Contributor

Description

Problem Statement

Solution Details

  • Implementation changes
  • Configuration updates
  • Documentation updates

Testing

Test Environment

  • OS:
  • SAP Version:
  • Database Type:

Test Cases

  • Unit tests added/updated
  • Manual Testing done

Checklist

  • Code follows project style guidelines
  • Documentation has been updated
  • Tests are passing
  • PR title follows conventional commit format
  • Breaking changes are clearly marked

Dependencies

  • Depends on: #issue_number

Screenshots/Logs

Additional Notes

dependabot bot and others added 30 commits August 19, 2025 11:16
@dependabot
Bump requests from 2.32.4 to 2.32.5 (Azure#105)
cd8bc9a
@dependabot
Bump requests from 2.32.4 to 2.32.5 (Azure#106)
d76cf8e
@devanshjainms
Add SAP Configuration Checks to STAF
e842c7b
@devanshjainms
Add configuration test type mappings to input-api.yaml
90130b3
@devanshjainms
Refactor collector and enums modules to relocate ApplicabilityRule de…
a964b05 
…finition and clean up imports
@devanshjainms
Add ApplicabilityRule dataclass to evaluate context-based checks
ab5b279
@devanshjainms
Add YAML parsing method to SapAutomationQA class
cca06c2
@devanshjainms
Refactor severity attribute in ConfigurationCheckModule to align with…
e507915 
… naming conventions
@devanshjainms
Fix YAML indentation for check ID in package.yml and import yaml modu…
df81445 
…le in sap_automation_qa.py
@devanshjainms
Add test_case_results and system_info parameters to HTMLReportRendere…
df312f0 
…r and update YAML task
@devanshjainms
Enhance ConfigurationCheckModule and HTMLReportRenderer with parallel…
c48064d 
… execution and retry capabilities
@devanshjainms
Enhance execute_checks_parallel method to include detailed execution …
20eb236 
…summary and status reporting
@devanshjainms
Increase max_workers to 20 for improved parallel execution in configu…
94b8d3d 
…ration checks
@devanshjainms
Refactor execute_checks_parallel method to improve code readability a…
c4eee21 
…nd maintainability
@devanshjainms
Implement command sanitization to prevent injection attacks and enhan…
4d88fdc 
…ce error handling in configuration checks
@devanshjainms
Refactor command and Azure-based configuration checks to use blocks f…
70f7f03 
…or improved error handling and logging
@devanshjainms
Refactor Azure command arguments for improved readability and consist…
c8a40cb 
…ency
@devanshjainms
Enhance Azure CLI commands with error handling and availability checks
258d3ce
@devanshjainms
Remove unnecessary escape characters from curl command in virtual_mac…
f992ece 
…hine.yml and clean up dangerous command patterns in commands.py
@devanshjainms
Refactor DANGEROUS_COMMANDS regex to improve command sanitization
5fec749
@devanshjainms
Remove unnecessary dangerous command patterns from DANGEROUS_COMMANDS…
641d853 
… list
@devanshjainms
Improve error handling in command execution and sanitization methods
af5265f
@devanshjainms
Update error count references in configuration checks to use 'FAILED'…
de41975 
… status and clean up HTML structure in report template
@devanshjainms
Add debug messages and role-specific checks for configuration validat…
afead41 
…ion in playbook
@devanshjainms
Fix file path for check file lookup and remove unnecessary comment in…
38c6b72 
… ASCS checks
@devanshjainms
Refactor load balancer check command and update file lookup path in c…
5f29d02 
…onfiguration tasks
@devanshjainms
Rename error status classes to 'failed' for consistency in report tem…
58dbc57 
…plate
@devanshjainms
Enhance configuration checks report with improved styling, animations…
b150d8c 
…, and responsive design elements
@devanshjainms
Add interactive filtering for configuration check statuses in report
8a750be
@devanshjainms
Refactor enumeration definitions in load_balancers.yml and virtual_ma…
885faa2 
…chine.yml for consistency
devanshjainms and others added 29 commits October 13, 2025 17:15
@devanshjainms
Enhance validation for HA Load Balancer configuration result to ensur…
f8e1764 
…e parameters are defined
@devanshjainms
Add check entry to report and handle undefined parameters in HA Load …
2d74ace 
…Balancer configuration
@devanshjainms
Update task name to specify collector type in check file parsing
4285a98
@devanshjainms
Enhance debug task to include verbosity and clarify check file loadin…
19a0e54 
…g message
@devanshjainms
Enhance debug task to include verbosity for better output clarity
872ae85
@devanshjainms
Add collector types for command and azure in high availability config…
9433139 
…uration
@devanshjainms
Remove Load Balancer checks and related result collection from config…
962e67f 
…uration checks
@devanshjainms
Refactor task names to include check type for improved clarity in con…
d46b462 
…figuration checks
@devanshjainms
Add ha_loadbalancer_config to system context for high availability ch…
cafb78c 
…ecks
@devanshjainms
Update Load Balancer configuration checks for clarity and add debug o…
ea501e6 
…utput
@devanshjainms
Refactor error message formatting and remove unnecessary 'become' dir…
a7b39a6 
…ectives in configuration check tasks
@devanshjainms
Refactor configuration check tasks for improved clarity and organization
ef2493d
@devanshjainms
Refactor variable names to uppercase for consistency and clarity in c…
ca4b567 
…onfiguration checks
@devanshjainms
Enhance FileSystemCollector to support ANF storage data and improve N…
ba68cae 
…FS correlation logic; update configuration checks to remove unnecessary OS version and adjust report formatting for clarity.
@devanshjainms
Update requirements and configuration checks for improved storage typ…
087dad6 
…e handling and report formatting
@devanshjainms
Update SUSE OS type references to "SLES" for consistency across confi…
159671f 
…guration files
@devanshjainms
Remove redundant comments and unnecessary verbosity in debug task for…
65dd809 
… clarity
@devanshjainms
Update SUSE OS type reference to "SLES_SAP" for consistency across co…
2e1588a 
…nfiguration files
@devanshjainms
Fix command syntax in HANA checks and update high availability agent …
2bff162 
…reference in SAP checks
@devanshjainms
Add verbosity to debug tasks for improved output clarity
35f1582
@devanshjainms
Enhance logging for data parsing in FileSystemCollector to improve tr…
457a03d 
…aceability and error handling
@devanshjainms
Add JSON formatting to ANF storage data collection for improved outpu…
a64dcdc 
…t structure
@devanshjainms
Add ANF volume information gathering to FileSystemCollector
b196555
@devanshjainms
Add ANF volumes parsing and context integration in AzureDataParser an…
33b955c 
…d ConfigurationCheckModule
@devanshjainms
Add check for ANF volumes configuration in SAP HANA
618506b
@devanshjainms
Add logging for mounted ANF IP addresses and metadata volume count in…
f430196 
… FileSystemCollector
@devanshjainms
Add ANF properties parsing in AzureDataParser and update storage type…
d1a38bc 
… in HANA checks
@devanshjainms
Refactor ANF logging in FileSystemCollector to consolidate messages a…
5cbca78 
…nd add debug information for skipped volumes
@devanshjainms
Merge branch 'development-oct-2025' into config-check-working
9da1825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@devanshjainms