Skip to content

Updated Key Vault #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Updated Key Vault #283

wants to merge 3 commits into from

Conversation

marvinbuss
Copy link
Collaborator

@marvinbuss marvinbuss commented Feb 2, 2022 •
edited
Loading

Summary of the Pull Request

  • Disable public network access on Key Vault

References

No references

PR Checklist

Validation Steps Performed

See automated checks

@marvinbuss marvinbuss added feature Feature Requests committed Committed item labels Feb 2, 2022
@marvinbuss marvinbuss added this to the v1.3.0 milestone Feb 2, 2022
@marvinbuss marvinbuss requested a review from a team as a code owner February 2, 2022 17:00
@marvinbuss marvinbuss self-assigned this Feb 2, 2022
marvinbuss
marvinbuss commented Feb 2, 2022
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

marvinbuss
marvinbuss commented Feb 2, 2022
View reviewed changes
Copy link
Collaborator Author

@marvinbuss marvinbuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marvinbuss marvinbuss marked this pull request as draft March 4, 2022 16:48
@mike-leuer
Copy link
Contributor

Can this get merged?
LGTM

@marvinbuss
Copy link
Collaborator Author

Closing because of #311

@marvinbuss marvinbuss closed this Jan 24, 2023
@marvinbuss marvinbuss deleted the marvinbuss/updated_keyvault branch January 24, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mike-leuer mike-leuer mike-leuer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@marvinbuss marvinbuss

Labels

committed Committed item feature Feature Requests

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@marvinbuss @mike-leuer