-
Notifications
You must be signed in to change notification settings - Fork 281
[MCP] Fixes and Refactoring execute_entity #2902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the execute-entity
built-in tool for the Model Context Protocol (MCP) to support execution of stored procedures or functions as DAB entities. The tool validates permissions, parses parameters, and executes stored procedures while providing comprehensive error handling.
- Adds ExecuteEntityTool class with execute operations for stored procedures/functions
- Implements parameter validation and authorization checks using existing DAB permissions
- Provides detailed error handling for SQL Server and generic database exceptions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few comments. I'll be waiting for the next PR with the refactoring :)
… Usr/sogh/execute-entity
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
LGTM!! |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 6 pipeline(s). |
Why make this change?
Closes on
execute_entity
[Enh]: Add DML tool:execute_entity
#2831What is this change?
This PR implements built-int tool execute_entity as part of built-in tools to support execution of stored procedures or functions.
entity
(required) name andparameters
(optional based on entity parameters signature) should be specified (see sample below)How was this tested?
Sample Request(s)
Execute stored procedure to read queries-
Execute stored procedure without parameters-