Skip to content

Update to communication-common latest beta #5845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
May 15, 2025
Merged

Update to communication-common latest beta #5845

merged 27 commits into from
May 15, 2025

Conversation

emlynmac
Copy link
Member

What

Roll beta version of azure communication-common in.
Requires updates to calling, chat and signalling.

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@emlynmac emlynmac requested review from a team as code owners May 13, 2025 21:51
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-hbjafqahnc.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-vpoirlxzfc.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-nxvfivefer.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-mmmqyqwomi.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-pjhlsksftr.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-irwmhxrwgh.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-qivwgixcln.chromatic.com/

@emlynmac emlynmac enabled auto-merge (squash) May 14, 2025 22:16
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-thvaktzolf.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wubhxiftlt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-dbmolpwcpv.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is decreased✅.

  • Current size: 1778342
  • Base size: 1785621
  • Diff size: -7279

@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12413574
  • Base size: 12413574
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is decreased✅.

  • Current size: 12413560
  • Base size: 12413561
  • Diff size: -1

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-wdvfmeiylg.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58492 / 94836
61.67%		 58492 / 94836
61.67%		 1186 / 2714
43.69%		 3387 / 5768
58.72%
Current 58493 / 94851
61.66%		 58493 / 94851
61.66%		 1186 / 2714
43.69%		 3396 / 5771
58.84%
Diff 1 / 15
-0.01%		 1 / 15
-0.01%		 0 / 0
0%		 9 / 3
0.12%

@github-actions GitHub Actions
Copy link
Contributor

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 29504 / 47062
62.69%		 29504 / 47062
62.69%		 815 / 1491
54.66%		 2451 / 3864
63.43%
Current 29499 / 47062
62.68%		 29499 / 47062
62.68%		 815 / 1491
54.66%		 2413 / 3845
62.75%
Diff -5 / 0
-0.01%		 -5 / 0
-0.01%		 0 / 0
0%		 -38 / -19
-0.68%

alkwa-msft
alkwa-msft reviewed May 15, 2025
View reviewed changes
samples/tests/package.json
"@azure/communication-common": "^2.3.1",
"@azure/communication-calling": "1.36.1-beta.1 || ^1.35.1",
"@azure/communication-chat": "1.6.0-beta.7 || ^1.5.4",
"@azure/communication-common": "^2.3.2-beta.1 || ^2.3.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit. I dont think wild cards work with non semver versions.

@emlynmac emlynmac merged commit c9071d1 into main May 15, 2025
41 checks passed
@emlynmac emlynmac deleted the emlyn/update-common-chat-azure-deps branch May 15, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkwa-msft alkwa-msft alkwa-msft approved these changes

@vhuseinova-msft vhuseinova-msft vhuseinova-msft approved these changes

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@carocao-msft carocao-msft Awaiting requested review from carocao-msft carocao-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@edwardlee-msft edwardlee-msft Awaiting requested review from edwardlee-msft edwardlee-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@mgamis-msft mgamis-msft Awaiting requested review from mgamis-msft mgamis-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

Assignees

@JoshuaLai JoshuaLai

@dmceachernmsft dmceachernmsft

@edwardlee-msft edwardlee-msft

@vhuseinova-msft vhuseinova-msft

Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emlynmac @alkwa-msft @vhuseinova-msft @JoshuaLai @dmceachernmsft @edwardlee-msft