Skip to content

Fix streaming upload #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix streaming upload #670

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3826f3
Fix streaming upload when blob size is unknown
rikonen Jun 25, 2020
8ee7dd5
Do not call tell() to fix streamed upload
rikonen Jun 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion azure-storage-blob/azure/storage/blob/_upload_chunking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ def __init__(self, blob_service, container_name, blob_name, blob_size,
self.chunk_size = chunk_size
self.stream = stream
self.parallel = parallel
self.stream_start = stream.tell() if parallel else None
self.stream_lock = Lock() if parallel else None
self.progress_callback = progress_callback
self.progress_total = 0
Expand All @@ -182,6 +181,8 @@ def get_chunk_streams(self):
while True:
if self.blob_size:
read_size = min(self.chunk_size - len(data), self.blob_size - (index + len(data)))
elif data:
read_size = self.chunk_size - len(data)
temp = self.stream.read(read_size)
temp = _get_data_bytes_only('temp', temp)
data += temp
Expand Down