[Functions] Legacy Event Hubs Checkpoint Fix #53342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The focus of these changes is to fix an issue where a legacy ownership record without checkpoint data was interpreted as a valid checkpoint and used to initialize a partition when no current generation checkpoint was present.
jsquire
added
Event Hubs
Client
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Event Hubs checkpoint store where legacy ownership records without checkpoint data (null or empty offset) were incorrectly interpreted as valid checkpoints. The fix ensures that only legacy records with valid offset data are used to initialize partitions, preventing the processor from starting at incorrect positions.
Key Changes:
- Removed fallback logic that allowed sequence numbers to be used when offset was invalid
- Added test coverage for legacy checkpoints with null or empty offset values
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sdk/eventhub/Microsoft.Azure.WebJobs.Extensions.EventHubs/CHANGELOG.md | Documents the bug fix in the changelog |
| sdk/eventhub/Azure.Messaging.EventHubs.sln | Removes two unused project references from solution file |
| sdk/eventhub/Azure.Messaging.EventHubs.Shared/tests/BlobCheckpointStore/BlobsCheckpointStoreInternalTests.cs | Adds test cases to verify legacy checkpoints without offset are properly rejected |
| sdk/eventhub/Azure.Messaging.EventHubs.Shared/src/BlobCheckpointStore/BlobCheckpointStoreInternal.cs | Removes the problematic sequence number fallback logic |
...re.Messaging.EventHubs.Shared/tests/BlobCheckpointStore/BlobsCheckpointStoreInternalTests.cs
Outdated
Show resolved
Hide resolved
…ointStore/BlobsCheckpointStoreInternalTests.cs Co-authored-by: Copilot <[email protected]>
m-redding
approved these changes
Oct 20, 2025
hmlam
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to fix an issue where a legacy ownership record without checkpoint data was interpreted as a valid checkpoint and used to initialize a partition when no current generation checkpoint was present.