Dynamic User Delegation SAS 101 #53288
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickliu-msft
requested review from
amnguye,
jalauzon-msft,
jaschrep-msft and
seanmcc-msft
as code owners
nickliu-msft
commented
Oct 16, 2025
| { | ||
| RecordingServiceVersion = StorageVersionExtensions.MaxVersion; | ||
| LiveServiceVersions = new object[] { StorageVersionExtensions.LatestVersion }; | ||
| LiveServiceVersions = new object[] { StorageVersionExtensions.MaxVersion }; |
There was a problem hiding this comment.
Todo: revert this at the end
API Change CheckAPIView identified API level changes in this PR and created the following API reviews Azure.Storage.Blobs |
nickliu-msft
commented
Oct 16, 2025
| EnsureState(); | ||
|
|
||
| stringToSign = ToStringToSign(userDelegationKey, accountName); | ||
| Console.WriteLine($"StringToSign = \n{stringToSign}\nEND"); |
There was a problem hiding this comment.
Todo: Remove this Console log and others
nickliu-msft
commented
Oct 16, 2025
| public string Permissions { get { throw null; } } | ||
| public string PreauthorizedAgentObjectId { get { throw null; } set { } } | ||
| public Azure.Storage.Sas.SasProtocol Protocol { get { throw null; } set { } } | ||
| public System.Collections.Generic.Dictionary<string, System.Collections.Generic.List<string>> RequestHeaders { get { throw null; } set { } } |
There was a problem hiding this comment.
Arch Board may want different name for this, leave as-is for now.
| EnsureState(); | ||
|
|
||
| stringToSign = ToStringToSign(userDelegationKey, accountName); | ||
| Console.WriteLine($"StringToSign = \n{stringToSign}\nEND"); |
nickliu-msft
commented
Oct 17, 2025
nickliu-msft
commented
Oct 17, 2025
| { | ||
| RecordingServiceVersion = StorageVersionExtensions.MaxVersion; | ||
| LiveServiceVersions = new object[] { StorageVersionExtensions.LatestVersion }; | ||
| LiveServiceVersions = new object[] { StorageVersionExtensions.MaxVersion }; |
There was a problem hiding this comment.
Todo: revert this at the end
nickliu-msft
commented
Oct 17, 2025
| EnsureState(); | ||
|
|
||
| stringToSign = ToStringToSign(userDelegationKey, accountName); | ||
| Console.WriteLine($"StringToSign = \n{stringToSign}\nEND"); |
There was a problem hiding this comment.
Todo: remove this at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.