Skip to content

Conversation

@bewatersmsft
Copy link
Member

Description

Multiple customers have complained of applying test changes to production workloads due to the What-If parameter being passed which comes from ShouldProcess. After reviewing the code, it is apparent there is no support for ShouldProcess and should be removed.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copilot AI review requested due to automatic review settings October 28, 2025 17:35
@azure-client-tools-bot-prd
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@bewatersmsft bewatersmsft changed the title Remove ShouldProcess Paramter from Azure Firewall related Resources Remove ShouldProcess Parameter from Azure Firewall related Resources Oct 28, 2025
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables incomplete SupportsShouldProcess functionality (which enables WhatIf/Confirm parameters) for four Network module cmdlets: Set-AzIpGroup, Set-AzFirewall, Set-AzFirewallPolicy, and Set-AzFirewallPolicyRuleCollectionGroup. The changes address issue #27667 by setting the SupportsShouldProcess attribute to false until proper implementation can be completed.

Key changes:

  • Disabled SupportsShouldProcess attribute in four cmdlet classes
  • Added TODO comments with issue reference to track future implementation
  • Updated ChangeLog.md to document the removal

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/Network/Network/IpGroup/SetIpGroupCommand.cs Disabled SupportsShouldProcess for Set-AzIpGroup cmdlet
src/Network/Network/AzureFirewall/SetAzureFirewallCommand.cs Disabled SupportsShouldProcess for Set-AzFirewall cmdlet
src/Network/Network/AzureFirewallPolicy/SetAzureFirewallPolicyCommand.cs Disabled SupportsShouldProcess for Set-AzFirewallPolicy cmdlet
src/Network/Network/AzureFirewallPolicy/RuleGroup/SetAzureFirewallPolicyRuleCollectionGroupCmdlet.cs Disabled SupportsShouldProcess for Set-AzFirewallPolicyRuleCollectionGroup cmdlet
src/Network/Network/ChangeLog.md Documented removal of SupportsShouldProcess from the four cmdlets

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@dolauli dolauli added the Contains Breaking Change This PR contains breaking change label Oct 29, 2025
@dolauli dolauli self-assigned this Oct 29, 2025
@github-actions
Copy link

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@dolauli
Copy link
Contributor

dolauli commented Oct 29, 2025

@bewatersmsft There are breaking changes detected that have not been preannounced. Either target the next breaking change window May 2026, or make sure the PR contains no breaking change.

Check the log of the static analysis pipeline for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants