-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Remove ShouldProcess Parameter from Azure Firewall related Resources #28766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables incomplete SupportsShouldProcess functionality (which enables WhatIf/Confirm parameters) for four Network module cmdlets: Set-AzIpGroup, Set-AzFirewall, Set-AzFirewallPolicy, and Set-AzFirewallPolicyRuleCollectionGroup. The changes address issue #27667 by setting the SupportsShouldProcess attribute to false until proper implementation can be completed.
Key changes:
- Disabled
SupportsShouldProcessattribute in four cmdlet classes - Added TODO comments with issue reference to track future implementation
- Updated ChangeLog.md to document the removal
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Network/Network/IpGroup/SetIpGroupCommand.cs | Disabled SupportsShouldProcess for Set-AzIpGroup cmdlet |
| src/Network/Network/AzureFirewall/SetAzureFirewallCommand.cs | Disabled SupportsShouldProcess for Set-AzFirewall cmdlet |
| src/Network/Network/AzureFirewallPolicy/SetAzureFirewallPolicyCommand.cs | Disabled SupportsShouldProcess for Set-AzFirewallPolicy cmdlet |
| src/Network/Network/AzureFirewallPolicy/RuleGroup/SetAzureFirewallPolicyRuleCollectionGroupCmdlet.cs | Disabled SupportsShouldProcess for Set-AzFirewallPolicyRuleCollectionGroup cmdlet |
| src/Network/Network/ChangeLog.md | Documented removal of SupportsShouldProcess from the four cmdlets |
Co-authored-by: Copilot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
To the author of the pull request, |
|
@bewatersmsft There are breaking changes detected that have not been preannounced. Either target the next breaking change window May 2026, or make sure the PR contains no breaking change. Check the log of the static analysis pipeline for details. |
Description
Multiple customers have complained of applying test changes to production workloads due to the
What-Ifparameter being passed which comes fromShouldProcess. After reviewing the code, it is apparent there is no support forShouldProcessand should be removed.Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.