Remove non sensitivity for DDoS ruleset #28757

baoqihuang0326 · 2025-10-27T22:34:52Z

Description

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2025-10-27T22:34:55Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

isra-fel · 2025-10-27T22:43:20Z

/azp run

azure-pipelines · 2025-10-27T22:43:36Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-28T17:08:19Z

/azp run

azure-pipelines · 2025-10-28T17:08:36Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-28T19:08:26Z

/azp run

azure-pipelines · 2025-10-28T19:08:45Z

Azure Pipelines successfully started running 3 pipeline(s).

github-actions · 2025-10-30T01:30:34Z

To the author of the pull request,
This PR was labeled "Contains Breaking Change" because breaking changes have been detected by the static analysis pipeline.

According to our policy, breaking changes can only take place during major release and they must be preannounced.
Please follow our guide on the detailed steps.
Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

dolauli · 2025-10-30T01:42:50Z

@baoqihuang0326 There are breaking changes detected that have not been preannounced. Either target the next breaking change window May 2026, or make sure the PR contains no breaking change.

Check the log of the static analysis pipeline for details.

isra-fel · 2025-10-30T17:08:20Z

/azp run

azure-pipelines · 2025-10-30T17:08:38Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-30T17:38:23Z

/azp run

azure-pipelines · 2025-10-30T17:38:41Z

Azure Pipelines successfully started running 3 pipeline(s).

dedhar · 2025-10-30T19:31:07Z

Do we need to add tests here https://github.com/Azure/azure-powershell/tree/main/src/Network/Network.Test/ScenarioTests

dedhar · 2025-10-30T19:32:22Z

Can you confirm if you can set DDoS RuleSet as RuleSet Type in PS

dedhar · 2025-10-30T19:33:55Z

Have we tested generated cmdlets once E2E to ensure all steps to set up DDoS Rule Set work E2E

dedhar · 2025-10-30T19:36:23Z

Sample tests

azure-powershell/src/Network/Network.Test/ScenarioTests/ApplicationGatewayTests.ps1

Line 4204 in 098c011

    
           $ddosmanagedRuleSet = New-AzApplicationGatewayFirewallPolicyManagedRuleSet -RuleSetType "Microsoft_HTTPDDoSRuleSet" -RuleSetVersion "1.0" -RuleGroupOverride $ruleGroupOverrideEntry

dedhar · 2025-10-30T19:37:37Z

Please check Shawn's PR for tests and lets add similar one for sensitivity and ruleset type https://github.com/Azure/azure-powershell/pull/25705/files#diff-e25e8ac41faf3f4f48ae0c984fae653f6551d79ff413c6c54ebfcb5f6a5fd567

baoqihuang0326 · 2025-10-30T19:56:01Z

Please check Shawn's PR for tests and lets add similar one for sensitivity and ruleset type https://github.com/Azure/azure-powershell/pull/25705/files#diff-e25e8ac41faf3f4f48ae0c984fae653f6551d79ff413c6c54ebfcb5f6a5fd567

We already have test case for the normal Sensitivity. I don't think we should add test for None Sensitivity which we are planning to remove it.

Shawnli222 · 2025-10-30T20:44:19Z

same comment as above, pls add a unit test would return error if the field is none for sensitivity

…value

isra-fel · 2025-10-30T23:08:22Z

/azp run

azure-pipelines · 2025-10-31T16:08:45Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-31T17:08:39Z

/azp run

azure-pipelines · 2025-10-31T17:08:58Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-31T18:09:28Z

/azp run

azure-pipelines · 2025-10-31T18:09:44Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-31T20:08:40Z

/azp run

azure-pipelines · 2025-10-31T20:08:57Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-31T22:38:33Z

/azp run

azure-pipelines · 2025-10-31T22:38:49Z

Azure Pipelines successfully started running 3 pipeline(s).

baoqihuang0326 · 2025-10-31T22:51:23Z

@microsoft-github-policy-service agree company="Microsoft"

baoqihuang0326 · 2025-10-31T22:52:27Z

@baoqihuang0326 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]
Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

isra-fel · 2025-11-01T02:13:22Z

/azp run

azure-pipelines · 2025-11-01T02:13:40Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-11-03T17:08:42Z

/azp run

azure-pipelines · 2025-11-03T17:09:00Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-11-03T18:08:53Z

/azp run

azure-pipelines · 2025-11-03T18:09:10Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-11-03T18:39:23Z

/azp run

azure-pipelines · 2025-11-03T18:39:42Z

Azure Pipelines successfully started running 3 pipeline(s).

Remove non sensitivity and commit change to 2025-03-01

c7d1464

isra-fel assigned dolauli Oct 28, 2025

add change log

87ad168

change the default value to Medium for sensitivity

0247e1d

dolauli added the Contains Breaking Change This PR contains breaking change label Oct 30, 2025

remove the has commit change

9993e7f

Add exception for the Sensitivity remove None

58c00f3

baoqihuang0326 requested a review from vidai-msft October 30, 2025 19:28

add ut for invalid sensitivity and revert the doc change for default …

ac4f102

…value

fix test

2e0ea7b

remove test and update the sensitivity to medium

c7414df

fix test

1350435

add more tests

5ebe82a

add test json

cf4f729

fix test

5dfb1d0

baoqihuang0326 added 2 commits November 3, 2025 17:59

revert everything

09fd8a8

revert everything

be68a4e

revert everything

e65e643

dolauli approved these changes Nov 4, 2025

View reviewed changes

dolauli merged commit f76dd2a into Azure:release-network-2025-03-01 Nov 4, 2025
12 checks passed

Remove non sensitivity for DDoS ruleset #28757

Remove non sensitivity for DDoS ruleset #28757

Uh oh!

Conversation

baoqihuang0326 commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Oct 27, 2025

Uh oh!

isra-fel commented Oct 27, 2025

Uh oh!

azure-pipelines bot commented Oct 27, 2025

Uh oh!

isra-fel commented Oct 28, 2025

Uh oh!

azure-pipelines bot commented Oct 28, 2025

Uh oh!

isra-fel commented Oct 28, 2025

Uh oh!

azure-pipelines bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

dolauli commented Oct 30, 2025

Uh oh!

isra-fel commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

isra-fel commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 30, 2025

Uh oh!

dedhar commented Oct 30, 2025

Uh oh!

dedhar commented Oct 30, 2025

Uh oh!

dedhar commented Oct 30, 2025

Uh oh!

dedhar commented Oct 30, 2025

Uh oh!

dedhar commented Oct 30, 2025

Uh oh!

baoqihuang0326 commented Oct 30, 2025

Uh oh!

Shawnli222 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isra-fel commented Oct 30, 2025

Uh oh!

azure-pipelines bot commented Oct 31, 2025

Uh oh!

isra-fel commented Oct 31, 2025

Uh oh!

azure-pipelines bot commented Oct 31, 2025

Uh oh!

isra-fel commented Oct 31, 2025

Uh oh!

azure-pipelines bot commented Oct 31, 2025

Uh oh!

isra-fel commented Oct 31, 2025

Uh oh!

azure-pipelines bot commented Oct 31, 2025

Uh oh!

isra-fel commented Oct 31, 2025

Uh oh!

azure-pipelines bot commented Oct 31, 2025

Uh oh!

baoqihuang0326 commented Oct 31, 2025

Uh oh!

baoqihuang0326 commented Oct 31, 2025

Uh oh!

isra-fel commented Nov 1, 2025

Uh oh!

azure-pipelines bot commented Nov 1, 2025

Uh oh!

isra-fel commented Nov 3, 2025

Uh oh!

baoqihuang0326 commented Oct 27, 2025 •

edited

Loading

Shawnli222 commented Oct 30, 2025 •

edited

Loading