Skip to content

Conversation

janielMartell
Copy link
Contributor

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 21:28
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR represents the general availability (GA) release of the Azure Trusted Signing PowerShell module, transitioning from preview to stable status. The changes update API versions, module metadata, and build configurations to reflect the production-ready state.

Key changes include:

  • Updated API version from preview (2024-09-30-preview) to GA (2025-10-13)
  • Incremented module version from 0.1.0 to 1.0.0
  • Added WhatIf/Confirm support to the CI Policy signing cmdlet

Reviewed Changes

Copilot reviewed 12 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Invoke-AzTrustedSigningCIPolicySigning.md Added WhatIf and Confirm parameter documentation for the CI Policy signing cmdlet
Az.TrustedSigning.psd1 Updated module manifest with new generation date, Az.Accounts dependency version, and formatting improvements
TrustedSigning.sln Restructured solution file with updated project references and build configurations
env.json Reordered test environment configuration properties
Test-AzTrustedSigningAccountNameAvailability.Recording.json Updated test recording with new GA API version and request identifiers
generate-info.json Updated generation ID for the AutoRest build
Az.TrustedSigning.md Updated module GUID in documentation
codeSigningAccounts*.json Updated API version references in UX configuration files
README.md Updated commit reference and module version for AutoRest generation
AssemblyInfo.cs Added copyright header and updated assembly version information
.gitignore Added exclusion for custom PowerShell module files

@isra-fel
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@isra-fel isra-fel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM with a question


# For new RP, the version is 0.1.0
module-version: 0.1.0
module-version: 1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reach out to us internally if you wish to GA the module

@Jaxelr Jaxelr self-requested a review October 14, 2025 10:29
@Jaxelr
Copy link
Member

Jaxelr commented Oct 14, 2025

Thanks for the review, @janielMartell lets talk about this internally as well.

@janielMartell janielMartell marked this pull request as draft October 14, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants