[RecoveryServices.Backup] [Ignite] Added support for vault soft delete #28620

hiaga · 2025-09-29T03:17:56Z

Description

Added support for vault soft delete

Mandatory Checklist

Please choose the target release of Azure PowerShell. (⚠️Target release is a different concept from API readiness. Please click below links for details.)
- General release
- Public preview
- Private preview
- Engineering build
- No need for a release
Check this box to confirm: I have read the Submitting Changes section of CONTRIBUTING.md and reviewed the following information:

SHOULD update ChangeLog.md file(s) appropriately
- Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
  - A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
- Should not change ChangeLog.md if no new release is required, such as fixing test case only.
SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
SHOULD have proper test coverage for changes in pull request.
SHOULD NOT adjust version of module manually in pull request

azure-client-tools-bot-prd · 2025-09-29T03:17:59Z

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copilot

Pull Request Overview

This PR adds support for vault soft delete functionality to the Azure Recovery Services module. The soft delete feature allows vaults to be recoverable for a retention period after deletion rather than being permanently removed.

Key changes include:

Addition of three new cmdlets for managing soft-deleted vaults and retrieving their backup items
Implementation of Azure Resource Graph (ARG) integration for querying soft-deleted vault backup items
Extended model classes to support soft-deleted vault scenarios

Reviewed Changes

Copilot reviewed 29 out of 110 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
UndoAzRecoveryServicesVaultDeletion.cs	Implements cmdlet to restore soft-deleted vaults to active state
GetAzureRmRecoveryServicesSoftDeletedVault.cs	Implements cmdlet to retrieve soft-deleted vaults by location and filters
GetAzureRmRecoveryServicesSoftDeletedVaultBackupItem.cs	Implements cmdlet to query backup items from soft-deleted vaults using ARG
PSRecoveryServicesVaultClient.cs	Adds client methods for soft-deleted vault operations
ConversionHelpers.cs	Adds conversion logic for ARG responses to backup item models
Multiple model files	Defines soft-deleted vault item classes extending existing backup item types
Help documentation	Provides comprehensive cmdlet documentation and usage examples

Comments suppressed due to low confidence (1)

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVaultBackupItem.md:1

The description should be 'Gets backup items from soft-deleted Recovery Services vaults' (plural) to match the cmdlet's functionality of querying multiple vaults.

---

Copilot · 2025-09-29T03:18:27Z

src/RecoveryServices/RecoveryServices/Vault/UndoAzRecoveryServicesVaultDeletion.cs

+    /// Undeletes a soft deleted Azure Recovery Services Vault.
+    /// </summary>
+    [Cmdlet("Undo", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "RecoveryServicesVaultDeletion", SupportsShouldProcess = true)]
+    [OutputType(typeof(Object))] // chck: ServeClientModel.OperationStatus


The comment contains a typo 'chck' which should be 'check'.

Copilot · 2025-09-29T03:18:27Z

src/RecoveryServices/RecoveryServices/Vault/UndoAzRecoveryServicesVaultDeletion.cs

+
+                    WriteVerbose($"Undelete operation completed for vault '{this.Name}'");
+
+                    this.WriteObject(new ARSSoftDeletedVault(undeleteResult)); // chck with Rishav what should be the output type here.


The comment contains a typo 'chck' which should be 'check'.

Suggested change

this.WriteObject(new ARSSoftDeletedVault(undeleteResult)); // chck with Rishav what should be the output type here.

this.WriteObject(new ARSSoftDeletedVault(undeleteResult)); // check with Rishav what should be the output type here.

isra-fel · 2025-09-29T03:31:05Z

/azp run

azure-pipelines · 2025-09-29T03:31:22Z

Azure Pipelines successfully started running 3 pipeline(s).

src/RecoveryServices/RecoveryServices.Management.Sdk/RecoveryServices.Management.Sdk.sln

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVault.md

VeryEarly

please fix failed test cases

hiaga · 2025-09-29T09:06:37Z

please fix failed test cases

rerecording the failed tests

src/RecoveryServices/RecoveryServices/ChangeLog.md

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVault.md

github-actions · 2025-10-02T07:43:09Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

isra-fel · 2025-10-28T04:10:55Z

/azp run

azure-pipelines · 2025-10-28T04:11:16Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-28T22:42:13Z

/azp run

azure-pipelines · 2025-10-28T22:42:34Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-29T01:06:00Z

LGTM with the only issue being having to delete the "PS C:" prompt from the examples

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVault.md

isra-fel · 2025-10-29T01:49:39Z

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVault.md

+
+### Example 2: Get a specific soft-deleted vault by name
+```powershell
+PS C:\> Get-AzRecoveryServicesSoftDeletedVault -Location "westus" -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e" -ResourceGroupName "wus-rg"


Suggested change

PS C:\> Get-AzRecoveryServicesSoftDeletedVault -Location "westus" -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e" -ResourceGroupName "wus-rg"

Get-AzRecoveryServicesSoftDeletedVault -Location "westus" -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e" -ResourceGroupName "wus-rg"

isra-fel · 2025-10-29T01:49:50Z

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVault.md

+
+### Example 3: Filter soft-deleted vaults by original vault name
+```powershell
+PS C:\> $sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus | Where-Object { $_.Properties.VaultId -match "wus-vault" }


Suggested change

PS C:\> $sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus | Where-Object { $_.Properties.VaultId -match "wus-vault" }

$sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus | Where-Object { $_.Properties.VaultId -match "wus-vault" }

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVaultBackupItem.md

isra-fel · 2025-10-29T01:50:52Z

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVaultBackupItem.md

+PS C:\> $sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e"
+PS C:\> Get-AzRecoveryServicesSoftDeletedVaultBackupItem -VaultName $sdVault.Name -ResourceGroupName $sdVault.ResourceGroupName


Suggested change

PS C:\> $sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e"

PS C:\> Get-AzRecoveryServicesSoftDeletedVaultBackupItem -VaultName $sdVault.Name -ResourceGroupName $sdVault.ResourceGroupName

$sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e"

Get-AzRecoveryServicesSoftDeletedVaultBackupItem -VaultName $sdVault.Name -ResourceGroupName $sdVault.ResourceGroupName

src/RecoveryServices/RecoveryServices/help/Undo-AzRecoveryServicesVaultDeletion.md

github-actions · 2025-10-29T01:54:21Z

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

isra-fel · 2025-10-29T04:39:32Z

/azp run

azure-pipelines · 2025-10-29T04:39:50Z

Azure Pipelines successfully started running 3 pipeline(s).

isra-fel · 2025-10-29T05:03:32Z

Please check the password detected by security tools

hiaga · 2025-10-29T05:18:55Z

@isra-fel I do not have access to check security tools

isra-fel · 2025-10-29T10:38:58Z

/azp run

azure-pipelines · 2025-10-29T10:39:19Z

Azure Pipelines successfully started running 3 pipeline(s).

docs updated

Copilot AI review requested due to automatic review settings September 29, 2025 03:17

hiaga added the needs-review label Sep 29, 2025

hiaga added this to the Az 14.5.0 (10/14/2025) milestone Sep 29, 2025

Copilot AI reviewed Sep 29, 2025

View reviewed changes

hiaga assigned VeryEarly Sep 29, 2025

VeryEarly reviewed Sep 29, 2025

View reviewed changes

src/RecoveryServices/RecoveryServices.Management.Sdk/RecoveryServices.Management.Sdk.sln Outdated Show resolved Hide resolved

VeryEarly reviewed Sep 29, 2025

View reviewed changes

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVault.md Outdated Show resolved Hide resolved

VeryEarly previously requested changes Sep 29, 2025

View reviewed changes

github-actions bot mentioned this pull request Oct 1, 2025

Monthly issue metrics report #28630

Closed

isra-fel changed the base branch from main to release-2025-10-14 October 2, 2025 07:16

isra-fel requested changes Oct 2, 2025

View reviewed changes

src/RecoveryServices/RecoveryServices/ChangeLog.md Outdated Show resolved Hide resolved

src/RecoveryServices/RecoveryServices/help/Get-AzRecoveryServicesSoftDeletedVault.md Outdated Show resolved Hide resolved

isra-fel added needs-revision and removed needs-review labels Oct 2, 2025

isra-fel assigned hiaga and unassigned VeryEarly Oct 2, 2025

isra-fel removed this from the Az 14.5.0 (10/14/2025) milestone Oct 12, 2025

hiaga added this to the Az 14.6.0 (11/04/2025) milestone Oct 25, 2025

hiaga force-pushed the hiaga/vsd branch from 8ef5f48 to 2ba5fa8 Compare October 27, 2025 18:08

hiaga requested review from NoriZC, Pan-Qi, YanaXu, dolauli, notyashhh, vidai-msft and wyunchi-ms as code owners October 27, 2025 18:08

hiaga added 2 commits October 29, 2025 03:19

re-recorded all tests

f1435d3

skip ASR test which need handling from ASR

4461b5b

hiaga added needs-review and removed needs-revision labels Oct 28, 2025

hiaga removed their assignment Oct 28, 2025

isra-fel requested changes Oct 29, 2025

View reviewed changes

isra-fel added needs-revision and removed needs-review labels Oct 29, 2025

isra-fel assigned hiaga Oct 29, 2025

updated examples

0baa36c

hiaga removed their assignment Oct 29, 2025

hiaga added needs-review and removed needs-revision labels Oct 29, 2025

secret redaction

a4e56b9

hiaga force-pushed the hiaga/vsd branch from 7f39ca1 to a4e56b9 Compare October 29, 2025 10:36

isra-fel approved these changes Oct 29, 2025

View reviewed changes

isra-fel merged commit 2648670 into Azure:release-2025-11-04 Oct 29, 2025
12 checks passed


		WriteVerbose($"Undelete operation completed for vault '{this.Name}'");

		this.WriteObject(new ARSSoftDeletedVault(undeleteResult)); // chck with Rishav what should be the output type here.

	PS C:\> Get-AzRecoveryServicesSoftDeletedVault -Location "westus" -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e" -ResourceGroupName "wus-rg"
	Get-AzRecoveryServicesSoftDeletedVault -Location "westus" -Name "wus-rg_fe7567gh-9d2b-4376-aa4a-de1c7176e40e" -ResourceGroupName "wus-rg"

	PS C:\> $sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus \| Where-Object { $_.Properties.VaultId -match "wus-vault" }
	$sdVault = Get-AzRecoveryServicesSoftDeletedVault -Location westus \| Where-Object { $_.Properties.VaultId -match "wus-vault" }

[RecoveryServices.Backup] [Ignite] Added support for vault soft delete #28620

[RecoveryServices.Backup] [Ignite] Added support for vault soft delete #28620

Uh oh!

Conversation

hiaga commented Sep 29, 2025

Description

Mandatory Checklist

Uh oh!

azure-client-tools-bot-prd bot commented Sep 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

isra-fel commented Sep 29, 2025

Uh oh!

azure-pipelines bot commented Sep 29, 2025

Uh oh!

Uh oh!

Uh oh!

VeryEarly left a comment

Choose a reason for hiding this comment

Uh oh!

hiaga commented Sep 29, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

isra-fel commented Oct 28, 2025

Uh oh!

azure-pipelines bot commented Oct 28, 2025

Uh oh!

isra-fel commented Oct 28, 2025

Uh oh!

azure-pipelines bot commented Oct 28, 2025

Uh oh!

isra-fel commented Oct 29, 2025

Uh oh!

Uh oh!

isra-fel Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

isra-fel Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

isra-fel Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

isra-fel commented Oct 29, 2025

Uh oh!

azure-pipelines bot commented Oct 29, 2025

Uh oh!

isra-fel commented Oct 29, 2025

Uh oh!

hiaga commented Oct 29, 2025

Uh oh!

isra-fel commented Oct 29, 2025

Uh oh!

azure-pipelines bot commented Oct 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!