Skip to content

Distributed Tracing for Entities (Isolated) #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: stevosyan/distributed-tracing-for-entities
Choose a base branch
from

Conversation

sophiatev
Copy link
Collaborator

@sophiatev sophiatev commented Mar 28, 2025

This PR adds support for distributed tracing for entities in the .NET isolated framework. The changes mostly focus on correctly propagating information between the durabletask and durabletask-dotnet repos. In order to do so, the proto definition of objects related to signaling entities or entities starting orchestrations had to be populated with extra information (like the parent trace context of the request, or the time of the request, etc. For more details see this PR in the protobuf repo). The changes in the ProtobufUtils class focus on adding this extra information. The changes in LocalGrpcListener are to:

  • Create a trace in the case of a client signaling an entity
  • Add the parent trace context created for a client starting an orchestration to the corresponding ExecutionStartedEvent, because I noticed that traces were not correctly being created in this case otherwise (this change is unrelated to tracing for entities).

The various other PRs related to this effort are

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation PR is ready to merge and referenced in pending_docs.md
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)
  • My changes do not require any extra work to be leveraged by OutOfProc SDKs
    • Otherwise: That work is being tracked here: #issue_or_pr_in_each_sdk
  • My changes do not change the version of the WebJobs.Extensions.DurableTask package
    • Otherwise: major or minor version updates are reflected in /src/Worker.Extensions.DurableTask/AssemblyInfo.cs
  • My changes do not add EventIds to our EventSource logs
    • Otherwise: Ensure the EventIds are within the supported range in our existing Windows infrastructure. You may validate this with a deployed app's telemetry. You may also extend the range by completing a PR such as this one.
  • My changes should be added to v2.x branch.
    • Otherwise: This change applies exclusively to WebJobs.Extensions.DurableTask v3.x. It will be retained only in the dev and main branches and will not be merged into the v2.x branch.

@sophiatev sophiatev requested a review from jviau April 3, 2025 19:09
Sophia Tevosyan added 15 commits April 11, 2025 17:10
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…ceContext for starting an orchestration in LocalGrpcListener
Sophia Tevosyan added 5 commits May 13, 2025 11:51
…yan/distributed-tracing-for-entities-isolated
…ner in the case that a request time wasn't attached to the signal entity request
…have to extract its value in TaskEntityShim for the activity for calling an entity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants