-
Notifications
You must be signed in to change notification settings - Fork 276
Distributed Tracing for Entities (Isolated) #3076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sophiatev
wants to merge
26
commits into
stevosyan/distributed-tracing-for-entities
Choose a base branch
from
stevosyan/distributed-tracing-for-entities-isolated
base: stevosyan/distributed-tracing-for-entities
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Distributed Tracing for Entities (Isolated) #3076
sophiatev
wants to merge
26
commits into
stevosyan/distributed-tracing-for-entities
from
stevosyan/distributed-tracing-for-entities-isolated
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…yan/distributed-tracing-for-entities-isolated
…ceContext for starting an orchestration in LocalGrpcListener
bachuv
reviewed
May 13, 2025
…yan/distributed-tracing-for-entities-isolated
…ner in the case that a request time wasn't attached to the signal entity request
…have to extract its value in TaskEntityShim for the activity for calling an entity
bachuv
reviewed
May 15, 2025
bachuv
approved these changes
May 15, 2025
…uest times DateTimeOffset
bachuv
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for distributed tracing for entities in the .NET isolated framework. The changes mostly focus on correctly propagating information between the durabletask and durabletask-dotnet repos. In order to do so, the proto definition of objects related to signaling entities or entities starting orchestrations had to be populated with extra information (like the parent trace context of the request, or the time of the request, etc. For more details see this PR in the protobuf repo). The changes in the
ProtobufUtils
class focus on adding this extra information. The changes inLocalGrpcListener
are to:ExecutionStartedEvent
, because I noticed that traces were not correctly being created in this case otherwise (this change is unrelated to tracing for entities).The various other PRs related to this effort are
Pull request checklist
pending_docs.md
release_notes.md
/src/Worker.Extensions.DurableTask/AssemblyInfo.cs
dev
andmain
branches and will not be merged into thev2.x
branch.