-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[containerapp] Fix containerapp update using yml file #31508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
I think the upgrade to the new API version (Azure#31276) lead to `runningStatus` appearing as a field at the top level when the YAML file passed to `az containerapp update` is run through the deserialiser. It then caused an error before the command was run: ``` (InvalidRequestContent) The request content was invalid and could not be deserialized: 'Could not find member 'runningStatus' on object of type 'ResourceDefinition'. Path 'runningStatus', line 1, position 224.'. ``` The fix is to add it to the existing list of readonly attributes to remove.
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
Hi @mbarton, |
Validation for Breaking Change Starting...
Thanks for your contribution! |
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Thank you for your contribution @mbarton! We will review the pull request and get back to you soon. |
Related command
az containerapp update
(passing--yaml
)Description
I think the upgrade to the new API version (#31276) lead to
runningStatus
appearing as a field at the top level when the YAML file passed toaz containerapp update
is run through the deserialiser.It then caused an error before the command was run:
The fix is to add it to the existing list of readonly attributes to remove.
Testing Guide
az containerapps show --output yaml > /tmp/template.yml
az containerapps update --yaml /tmp/template.yml
Example Python script here: https://github.com/rcpch/national-paediatric-diabetes-audit/blob/live/s/deploy-revision.py
History Notes
[Container App]
az containerapp update
Modify--yaml
template handling to fixrunningStatus
errorThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.