Skip to content

dev: add support for lazy-loading description/deprecationReason config values #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

justlevine
Copy link
Member

@justlevine justlevine commented May 3, 2025

What

This PR as support for making description and deprecationMessage fields lazy-loadable, while supporting backcompat.

Why

Part of wp-graphql/wp-graphql#3354

How

Testing Instructions

Additional Info

A new AxeWP\GraphQL\Helper\Compat::resolve_graphql_config() method

Checklist:

  • My code is tested to the best of my abilities.
  • My code follows the WordPress Coding Standards.
  • My code has proper inline documentation.
  • I have added unit tests to verify the code works as intended.
  • The changes in this PR have been noted in CHANGELOG.md

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 5004 lines exceeds the maximum allowed for the inline comments feature.

@justlevine
Copy link
Member Author

Validated passing locally with WPGraphQL v1.26.0. Will wait until the wp-graphql-plugin-boilerplate release before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant