-
Notifications
You must be signed in to change notification settings - Fork 2k
Align magic login confirmation layout #107181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: update/magic-login-footer-text
Are you sure you want to change the base?
Align magic login confirmation layout #107181
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
|
@jasmussen this is a follow-up to my comment in #107130 (comment) It aligns the footer text used in the code confirmation pages to match structurally with the remaining footers in other Login pages. The link colors no longer apply the Jetpack palette (or other palettes when magic code is ported to other OAuth clients). If we want to bring that back, then we can do so. I recall a discussion about links in the footer and sub-header or the top-bar not to be colored or accented. It's the same color variation used in the sub-header now. Do you mind taking a look and letting me know what works? :-) |
|
Thanks for the ping. Jetpack looks great for anyone who might glance at this, and wonder: why remove the spot color from links? If I recall correctly, it's because other consumers, like Blaze, uses an orange color that would not meet text contrast in that context, so keeping them all a single color provides a uniform legible baseline. If I remembered that right, then on principle this seems fine to me, even if I will be missing the green links a little bit, but no strong opinions. One thing though, the font weight change. I don't think we're changing the font weight on links in the broader system, they still have the same weight as the surrounding text, they're just underlined. It's possible there's a decision somewhere that introduced it, I'd love that context if possible. But absent that, I think we should omit the font weight change, keep it simple. One more thing: I believe "wordpress-blue" has been deprecated in Studio, because it's meant to be the default blue. So you should be able to just use --studio-blue. |
|
Thanks @jasmussen . Yes, I recall same convo. Also that we'd want to not highlight things outside the main form controls/CTA. But if the green/JP color is subtle here and we want to bring it back, an exception, then happy to do that. Otherwise I will proceed like you mentioned.
Will do! It was my guess, seeing as we have bolder font when it's only a single link, like "lost password" or "use a password instead". I will nudge you back in a bit with the changes. Thanks! |
|
Let's see if @keoshi has instincts, otherwise I'd move forward. |
|
Ok. Thanks again @jasmussen . I think it should all be addressed now. I also spotted one inconsistency that has been fixed now (the font size on the first link was smaller than the rest). So this is how it looks with the latest changes:
p.s. We also fixed the login link confirmation page, which was not properly aligned either. Text had a different color and decorations:
Ah. This was leftover code that I've completely removed now. Let me know if you spot anything else or anything to change. Otherwise, will wait for @keoshi :-) |
|
Thanks for the ping! Change looks good to me in the context of cohesion between all login screens. The only thing I see (and it might just be the screenshots above tricking my eyes) is that the color of the accessory text seems a tad lighter than the one in |
|
Thanks @keoshi !
Hmm not that I recall. We can update them if something feels better. Currently subheader and footer are
|








Part of https://linear.app/a8c/issue/DSGCOM-153/login-magic-code-on-confirm-page-update-footer-to-a-tertiary-resend
Proposed Changes
OneLoginFooterto accept optional children and adjust its styles so inline paragraphs can share the same typography and link treatments as the other login views.OneLoginFooter, remove bespoke classes, and wrap the forms so the padding/margins match the request page..magic-login__successfully-jetpackso the confirmation cards keep the same bottom margin and padding as.form-fieldset/.card.logged-out-form.Why are these changes being made?
OneLoginFooterkeeps every login step visually consistent and avoids one-off Jetpack-only styles.Testing Instructions
/log-in/linkand/log-in/jetpack/link, trigger the confirmation flow, and confirm the footers render as a single paragraph with consistent fonts/colors and default link hover behavior.Pre-merge Checklist