Improve WP Stream Connector mock log method signature #2370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the mock log() method in the Stream Connector test to match the actual WP Stream Connector API signature. This improves test accuracy and code maintainability by using the correct parameter names and adding proper documentation. Changes: - Update method signature to use actual parameters (message, args, object_id, context, action, user_id) - Add detailed PHPDoc with parameter descriptions and return type - Add return true statement for proper mock behavior - Update phpcs ignore annotations
obenland
added
the
Skip Changelog
obenland
added
the
Skip Changelog
There was a problem hiding this comment.
Pull Request Overview
This PR improves the test accuracy of the WP Stream Connector mock by aligning its log() method signature with the actual WP Stream Connector API. The changes ensure better code maintainability and proper documentation of the mock implementation.
Key Changes
- Updated mock
log()method signature to match the actual API with six parameters instead of one - Added comprehensive PHPDoc documentation with parameter descriptions and return type
- Added explicit
return truefor proper mock behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Updates the mock
log()method in the Stream Connector test to match the actual WP Stream Connector API signature. This improves test accuracy and code maintainability by using the correct parameter names and adding proper documentation.Changes:
$message,$args,$object_id,$context,$action,$user_id)return truestatement for proper mock behaviorOther information:
Testing instructions:
This is a code cleanup/refactoring change to the test mock. To verify:
npm run env-testto ensure all tests still pass