Support Non-Figma Design Systems like CDT #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingeniumed
changed the title
ingeniumed
commented
Sep 14, 2023
ingeniumed
changed the title
ingeniumed
changed the title
…on using a tokenMap
ingeniumed
commented
Sep 14, 2023
ingeniumed
changed the title
smithjw1
approved these changes
Sep 14, 2023
smithjw1
left a comment
smithjw1
left a comment
There was a problem hiding this comment.
This looks great! A few comments that aren't necessary to merge this PR, but something to consider for future work.
…ens into the mapping file
Contributor
Author
|
Here is a screenshot of inserting the values from the top tokens extracted from cagov.css into the twentytwentythree theme. I've used the following blocks:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(This is a re-creation of #31 as it was accidentally closed)
The purpose of this PR is to support non-figma design systems, such as CDT as a source of truth.
This PR includes 3 key files:
theme.jsonthat can be used if one doesn't already exist.topTokens.txtthat shows the tokens in thetheme.jsonprovided.token-map.jsonthat maps the tokens we have defined intheme.json'ssettings.customto the ones found in a CSS file. Currently the values line up with thecagov.cssfound here.Once this PR is complete,
topTokens.txtwill be deleted and the referencetoken-map.jsonwill be overriden via CLI arg so it can be tweaked to one's liking.This will fix #32.