Skip to content

refactor(dev-env)!: replace vipdev.lndo.site with vipdev.site #1984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

refactor(dev-env)!: replace vipdev.lndo.site with vipdev.site #1984

wants to merge 2 commits into from

Conversation

@sjinks
Copy link
Member

@sjinks sjinks commented Aug 7, 2024 •
edited
Loading

Description

This PR replaces vipdev.lndo.site with vipdev.site in the codebase.

The migration from vipdev.lndo.site to vipdev.site will be handled elsewhere (Automattic/vip-container-images#851).

Pull request checklist

New release checklist

Steps to Test

TBD.

@sjinks sjinks added [Status] Needs Review [Status] Needs Docs The feature or update requires an update to our public VIP Documentation DO NOT MERGE labels Aug 7, 2024
@sjinks sjinks self-assigned this Aug 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@sjinks sjinks marked this pull request as ready for review August 7, 2024 15:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sjinks
Copy link
Member Author

sjinks commented Aug 7, 2024

Automattic/vip-container-images#851

@sjinks sjinks requested a review from rinatkhaziev August 8, 2024 02:03
@rinatkhaziev
Copy link
Contributor

rinatkhaziev commented Aug 8, 2024

Does this need a test for the migration?

@sjinks
Copy link
Member Author

sjinks commented Aug 8, 2024

There is not much to test here... The actual migration happens in the WordPress installation script in Automattic/vip-container-images#851 - specifically, https://github.com/Automattic/vip-container-images/pull/851/files#diff-ad8cc8dcf9efb7506300a53b2cf5754bf370da1daa148bf33304572c6a8050f7R206-R214

@sjinks sjinks mentioned this pull request Aug 19, 2024
Open
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

@github-actions github-actions bot closed this Oct 15, 2024
@sjinks sjinks added [Status] Keep Prevent the "stale" workflow from auto-closing and removed [Status] Stale [Status] Autoclosed [Status] Needs Docs The feature or update requires an update to our public VIP Documentation labels Oct 19, 2024
@sjinks sjinks reopened this Oct 19, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rinatkhaziev rinatkhaziev rinatkhaziev approved these changes

Assignees

@sjinks sjinks

Labels

DO NOT MERGE [Status] Keep Prevent the "stale" workflow from auto-closing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjinks @rinatkhaziev