Skip to content

Conversation

@sejas
Copy link
Member

@sejas sejas commented Oct 22, 2025

Related issues

Proposed Changes

  • Update SQLite integration plugin, so it works for any DB_NAME

Testing Instructions

  • Apply this branch and run npm i && npm start
  • Create a new site
  • Edit wp-config.php and set define( 'DB_NAME', 'antyhing_here' );
  • Confirm the site works as expected
  • Restart the site
  • Confirm the site is still working
  • Test other features to confirm there are no regressions, such as exporting the database or importing a backup.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Oct 22, 2025
@sejas sejas marked this pull request as ready for review October 23, 2025 02:01
…te-integration-plugin-with-smart-database-name
@sejas sejas requested a review from a team October 23, 2025 02:30
@github-actions
Copy link

📊 Performance Test Results

Comparing b7ae944 vs trunk

site-editor

Metric trunk b7ae944 Diff Change
load 8399.00 ms 12123.00 ms +3724.00 ms 🔴 44.3%

site-startup

Metric trunk b7ae944 Diff Change
siteCreation 22255.00 ms 21330.00 ms -925.00 ms 🟢 -4.2%
siteStartup 6969.00 ms 5984.00 ms -985.00 ms 🟢 -14.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@sejas sejas mentioned this pull request Oct 23, 2025
1 task
Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A site with an incorrect database name now functions properly.

Other use cases like adding a site, importing, exporting work,too.

@sejas sejas merged commit f003a38 into trunk Oct 23, 2025
14 checks passed
@sejas sejas deleted the update/sqlite-integration-plugin-with-smart-database-name branch October 23, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants