Skip to content

Conversation

@sejas
Copy link
Member

@sejas sejas commented Oct 10, 2025

Related issues

Related to:

Proposed Changes

  • Upgrade SQLite database integration to 2.2.12 to fix CHECK constraint query.

Testing Instructions

  • Run npm start
  • Start a site
  • Confirm it works as expected
  • Confirm the sqlite plugin has been updated to the new version 2.2.12
  • Go to the import tab
  • Drag an drop this SQL dump: check-my-table.sql
  • Confirm the create table with the Check constraint is executed correctly

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

@sejas sejas self-assigned this Oct 10, 2025
@sejas sejas requested a review from a team October 10, 2025 11:13
Copy link
Contributor

@epeicher epeicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sejas ! I can confirm that the import with the check constraint works as expected now, while it is failing in trunk. Also, starting as site works as expected. LGTM! :shipit:

Image
CleanShot.2025-10-10.at.13.18.13.mp4

Copy link
Contributor

@wojtekn wojtekn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue on my local - I can import the attached SQL without problem now.

I also tested my import files: Jetpack, Wpress, Local, Playground, and Studio, and all of them still work fine.

@github-actions
Copy link

📊 Performance Test Results

Comparing 16debfb vs trunk

site-editor

Metric trunk 16debfb Diff Change
load 11881.00 ms 12058.50 ms +177.50 ms 🔴 1.5%

site-startup

Metric trunk 16debfb Diff Change
siteCreation 10965.00 ms 11952.00 ms +987.00 ms 🔴 9.0%
siteStartup 3912.00 ms 3918.00 ms +6.00 ms 🔴 0.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@sejas sejas merged commit e9f3bcd into trunk Oct 10, 2025
13 checks passed
@sejas sejas deleted the update/sqlite-database-integration-version-plugin-check-constraint branch October 10, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants