-
Notifications
You must be signed in to change notification settings - Fork 49
Add Beta Features menu #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Add Beta Features menu #1860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as described and a nice addition in my opinion!
LGTM 👍
@bcotrim Thank you for your review. Your Feature Flags menu implementation paved the way. 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally, this works for me and I did not run into any issues 👍
I had one suggestion about the naming: to me, as a user with little context, it was not really clear what Studio Sites CLI
did, especially since there was also Install CLI...
command that was in the top menu. Perhaps we could improve the naming there
@katinthehatsite, do you see any short name we could use instead of the current one to make it more descriptive? Alternatively, we could use the menu description. It looks like that on macOS: ![]() I'm unsure how it works on Windows, though. |
71d0094
to
bb91703
Compare
📊 Performance Test ResultsComparing a9bfcfb vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
Oh I think this is very nice, let's do that. It would give users a brief idea of what the feature 👍 Worst case, we can try to limit it to Mac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enableBlueprints: boolean; | ||
} | ||
|
||
// eslint-disable-next-line @typescript-eslint/no-empty-object-type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems we don't need it. Also we can remove it from FeatureFlags
.
// eslint-disable-next-line @typescript-eslint/no-empty-object-type |
description?: string; | ||
} | ||
|
||
export const BETA_FEATURES_DEFINITION: Record< keyof BetaFeatures, BetaFeatureDefinition > = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it's not used outside
export const BETA_FEATURES_DEFINITION: Record< keyof BetaFeatures, BetaFeatureDefinition > = { | |
const BETA_FEATURES_DEFINITION: Record< keyof BetaFeatures, BetaFeatureDefinition > = { |
export const BETA_FEATURES: Record< keyof BetaFeatures, BetaFeatureDefinition > = | ||
BETA_FEATURES_DEFINITION; | ||
|
||
export function buildBetaFeatures( userData: BetaFeatures | undefined ): BetaFeatures { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export function buildBetaFeatures( userData: BetaFeatures | undefined ): BetaFeatures { | |
function buildBetaFeatures( userData: BetaFeatures | undefined ): BetaFeatures { |
Related issues
Proposed Changes
appdata-v1.json
for cross-app/CLI accessbetaFeatures.studioSitesCli
from appdata instead ofENABLE_CLI_V2
environment variablestudio site
command when the beta feature is enabledTesting Instructions
Testing the Beta Features Menu
Testing CLI Integration
npm run make
node dist/cli/main.js --help
site
command is NOT listednode dist/cli/main.js --help
site Manage local sites (Beta)
command is now listednode dist/cli/main.js site list
Verify Persistence
~/Library/Application Support/Studio/appdata-v1.json
(macOS) or equivalent"betaFeatures": { "studioSitesCli": true }
Pre-merge Checklist