Simplify edit site state when called from context menu in the sidebar #1807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sejas
changed the title
sejas
commented
Sep 22, 2025
Comment on lines
+215
to
+219
| if ( site.id !== selectedSite?.id ) { | ||
| setSelectedSiteId( site.id ); | ||
| } | ||
| setSelectedTab( 'settings' ); | ||
| setIsEditModalOpen( true ); |
There was a problem hiding this comment.
I moved the logic to select the site, the settings tab and open the modal right to the place it triggers the event.
katinthehatsite
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm startPre-merge Checklist