Forms: Fix slider filter borders #46182
Open
+62
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vianasw
added
[Type] Bug
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
github-actions
bot
added
[Block] Contact Form
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Increases CSS specificity for slider text label inputs to override theme styles. The Assembler theme (and potentially others) was adding borders to these inputs in the editor. Fixed by: - Doubling class selectors for higher specificity - Adding outline: none and box-shadow: none to cover all border-like styles
vianasw
force-pushed
the
fix/forms-slider-filter-borders
branch
from
3467579 to
73194e8
Compare
The doubled selector approach didn't provide enough specificity against the Assembler theme. This commit uses !important flags to ensure our styles override theme editor styles. Changes: - Remove doubled class selectors (didn't work) - Add !important to all style declarations - Add font-size: 0.9em to fix "bigger inputs" issue - Add line-height, height, and vertical-align controls for proper sizing - Ensures text labels match intended design regardless of theme Fixes FORMS-445
Apply the same fix to the min/max number inputs that was applied to the text labels. This ensures the number inputs also properly override theme styles in the editor. Changes: - Add !important to border, outline, box-shadow (removes borders) - Add !important to background, font properties, colors - Add !important to padding, margin, width, height - Add line-height and vertical-align for consistent sizing - Add outline: none to prevent focus outlines from themes
vianasw
added
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FORMS-445
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
Before:
After:
