Skip to content

Conversation

dilirity
Copy link
Member

@dilirity dilirity commented Sep 3, 2025

Fixes HOG-333

Proposed changes:

  • Fix images added via blocks from the Breakdance editor not being served through CDN.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

HOG-333

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • You need Breakdance from https://breakdance.com/ and Boost (free works) or Jetpack on a website that can run Image CDN. You'll have to sign up to breakdance to download the free version.
  • After setting up Breakdance, make sure Image CDN is enabled either via the Boost settings or via Jetpack's Performance tab (Site accelerator), or via the Jetpack Modules page;
  • Edit a page using the Breakdance editor and add an Image block (it might take a while for the blocks to load);
CleanShot 2025-09-03 at 16 50 12@2x CleanShot 2025-09-03 at 16 50 22@2x
  • Visit the page in the front-end and check the image URL - it should be served via CDN:
CleanShot 2025-09-03 at 16 51 27@2x

@dilirity dilirity self-assigned this Sep 3, 2025
@dilirity dilirity added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the add/image-cdn/breakdance-compatibility branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack add/image-cdn/breakdance-compatibility

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Package] Image CDN [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Sep 3, 2025
Copy link
Contributor

github-actions bot commented Sep 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link

jp-launch-control bot commented Sep 3, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/image-cdn/src/class-image-cdn-core.php 86/137 (62.77%) -0.46% 1 ❤️‍🩹

1 file is newly checked for coverage.

File Coverage
projects/packages/image-cdn/src/compatibility/breakdance.php 4/5 (80.00%) 💚

Full summary · PHP report · JS report

LiamSarsfield
LiamSarsfield previously approved these changes Sep 5, 2025
Copy link
Contributor

@LiamSarsfield LiamSarsfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can confirm this works as expected 🚀

Just 1 nit would be I wonder if we could add unit tests to this like Activitypub_Compat_Test.php

@dilirity dilirity added [Tests] Includes Tests and removed I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels Sep 5, 2025
@dilirity
Copy link
Member Author

dilirity commented Sep 5, 2025

@LiamSarsfield thanks. I've included a test for that.

I noticed the other compatibilities have a pattern to init their code on plugins_loaded instead of when the file is included. So I updated this compatibility to follow that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Package] Image CDN [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] Needs Review This PR is ready for review. [Tests] Includes Tests [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants