Improve DUX for create-guest-authors command
#377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead of concatenating and echoing strings.
…-emails Send moderation email even if guest author has no email address
Better formatting for metabox_manage_guest_author_bio()
Update CLI to use cached functions
Not really being used in other tests
We can use these to verify that our author query mods work
And add an additional test for post_author + tax query
Known issue in CAP
We need to check for both INNER and LEFT JOINs to avoid adding a dupe query which leads to query errors in 4.6+. See Automattic#374
The biggest part of this change is to add a progress bar for `wp co-authors-plus create-guest-authors`. When doing a mass conversion, it's nice to be able to get a sense of "I should go eat lunch now, this is going to take a while" or "I shouldn't bother switching from Red to 1989, this will be done so quickly I may as well have Red play a third time in a row" or anything in between. This uses `WP_CLI\Utils\make_progress_bar` to create a progress bar. Additionally, it adds the count of how many accounts will be attempted at the start in order to further improve the Developer User experience See http://wp-cli.org/docs/internal-api/wp-cli-utils-make-progress-bar/
|
Neat! Can you share a screenshot of what it looks like? |
|
Here are a couple of screenshots. The last two also inlcude another change I'm proposing seperately (so ignore the additional params) |
|
Only the last commit is relevant here. Looks like a progress bar had been added in the meantime. The only thing not added was:
I like that, so I'm leaving this PR open on a milestone as a reminder to add that in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest part of this change is to add a progress bar for
wp co-authors-plus create-guest-authors.When doing a mass conversion, it's nice to be able to get a sense of "I should go eat lunch now, this is going to take a while" or "I shouldn't bother switching from Red to 1989, this will be done so quickly I may as well have Red play a third time in a row" or anything in between. This uses
WP_CLI\Utils\make_progress_barto create a progress bar.Additionally, it adds the count of how many accounts will be attempted at the start in order to further improve the Developer User experience
See http://wp-cli.org/docs/internal-api/wp-cli-utils-make-progress-bar/