fix recording multiple times on the same page, need to listen to the corresponding runtime.onMessage #2073
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, need to listen to the corresponding runtime.onMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When recording is stopped for the first time, mainFrame receives the recording:stop message, and destroyRecordEvents clears the operation event listener bound to the document. At this time, when recording is started for the second time on the current page, the document will be monitored again. However, due to the existence of the #automa-recording element, runtime.onMessage will not listen. As a result, when recording is stopped for the second time, the recording:stop message cannot be received as expected, and the destroyRecordEvents operation cannot be performed, resulting in the document not destroying the listener. At this time, when recording is started for the third time, click and other operations will cause repeated listening.