Skip to content

Conversation

ryanzhangofficial
Copy link
Member

@ryanzhangofficial ryanzhangofficial commented Aug 15, 2025

Task

Make sure all robots or fields in spawn assets are under their corresponding type.

Symptom

Currently, if you import a custom robot file under the fields tab, it is correctly shown under the robots tab in Configure Assets, but stays under the fields tab in Spawn Assets.

Solution

Correctly infer actual asset type when caching and spawn using entry's own type and actual object type.

Verification

Imported dozer mira file in field tab, and it appears under robot in spawn assets now.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@ryanzhangofficial ryanzhangofficial self-assigned this Aug 15, 2025
@ryanzhangofficial ryanzhangofficial requested review from a team as code owners August 15, 2025 15:59
@ryanzhangofficial ryanzhangofficial added the ui/ux Relating to user interface, or in general, user experience label Aug 15, 2025
@rutmanz
Copy link
Member

rutmanz commented Aug 15, 2025

Duplicate of AARD-2069 and is also addressed by #1273.

This approach also doesn't allow for gamepiece assets (which can't be distinguished internally by the .dynamic field

@PepperLola
Copy link
Member

PepperLola commented Aug 20, 2025

Closing in favor of #1273 which fixes the same issue and needs to be merged anyway

@PepperLola PepperLola closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux Relating to user interface, or in general, user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants