-
Notifications
You must be signed in to change notification settings - Fork 61
Add Confirmation Before Dev Tool Removal and Modification [AARD-2033
]
#1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add Confirmation Before Dev Tool Removal and Modification [AARD-2033
]
#1265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to say that the zones were defined in the field file/asset file/mirabuf file and avoid all reference to the developer tools. I think that, in theory, the developer tools are used by us to add this information to the cached files that people download, and so we shouldn't expect that they've used them / know they're there.
Also, this doesn't handle modifying the zones
AARD-2033
]AARD-2033
]
6f24ff1
to
988f39a
Compare
actionType?: "removal" | "modification" | ||
} | ||
|
||
const DevtoolZoneRemovalModal: React.FC<DevtoolZoneRemovalModalProps> = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should probably be renamed if this is being generalized
1f46d28
to
273982e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise lgtm
Why are we only adding this confirmation for scoring zones? Also Biome test fail |
As noted in comments in code, protected zones are not supported yet. |
Yeah, I can see that, I am just wondering why we are only adding this for scoring zones. Are we planning to add this for protected zones later on? From a user perspective it feels weird if they are only getting the popup for scoring zones, and nothing else. |
Yes that's the plan. I think the order of merging should be this PR -> Zach's protected zone pr -> protected zone removal and modification |
Is it also intentional that you have to go into developer tools and press save to actually have scoring zones persist in cache? Currently spawning in a scoring zone and then refreshing doesn't have it persist. If this is the case, I am personally not a fan of this, and think that they should auto cache. Screen.Recording.2025-08-19.at.9.29.14.AM.mov |
I agree with @AlexD717, but this appears to be the current behavior on dev as well |
Yes I agree too, currently fixing this issue. It isn't a problem on prod so must've been an issue that came up throughout the summer. |
Would appreciate thoughts on this approach. I thought it would be appropriate because of the rewording of the modals, but at the same time it makes devtools seem less useful. |
Task
Add a confirmation dialog when removing a Dev Tools–placed scoring zone, allowing the user to either remove it temporarily (current behavior) or permanently by also deleting it from the Dev Tools cache.
Jira Ticket
Symptom
Currently if you remove a protected zone or scoring zone from the configure field panel that is placed by the dev tool it will remove it until the next refresh. Only the dev tool is able to cache scoring zone placement.
Solution
Popup a confirmation window when we remove a scoring zone that was placed by dev tools, and give us the option of removing it from dev tools as well (saving to cache).
Verification
Before merging, ensure the following criteria are met: