Skip to content

Convert depth to meters #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert depth to meters #7

wants to merge 1 commit into from

Conversation

efernandez
Copy link

@efernandez efernandez commented Mar 5, 2019 •
edited
Loading

The depth in float format should represent meters, not millimeters.

Before this PR:
screenshot from 2019-03-05 19-24-40

You can clearly see that the values are saturated to black and white because the values in the image are 1000 times larger than they should.

After this PR:
screenshot from 2019-03-05 19-23-33

Obviously, the color image is completely broken.

It's a shame though that the ST SDK doesn't support the uint16_t format.

@efernandez efernandez mentioned this pull request Mar 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@efernandez