Life DTs #21501
Closed
Life DTs #21501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!review |
|
closing this because I actually need to touch waaaaaay more things to make this work, this PR fundamentally breaks pain because pain was never designed with only doing half of something in half a second in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes most of the Process() life calls to use seconds_per_tick, making them "Tick Invariant". Meaning the amount of something that happens over time will happen at the same rate regardless of server lag. I have only barely tested this to make sure nothing crashes, mostly verifying that the game's damage systems still work. This should probably be test merged before actually merging it to the repo.