SCCV Horizon Aft Extension & Partial Remap #21495
Conversation
Batrachophreno
requested review from
DreamySkrell and
JohnWildkins
as code owners
github-actions
bot
added
Javascript
|
!review |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
|
This will need more eyes given the nature of large scale remaps, for now here's your initial shopping list! Some doors throughout the map are 1 tile off from the place they should be at List of locations
X: 103, Y: 159, D1 
X: 112, Y: 160, D1 
X: 135, Y: 155, D3 A list of some pipe/cable errors List
This tile has a SMES, lacks a node connected to the grid to the right 
This area in front of the vault needs an apc 
New vault's turret controls needs to be pixel-shifted toward the wall. Also please use the Additionally it'd be helpful if bolt control buttons stated explictly which vault door has been opened in the command comms, unless what's intended here is to confuse the heads 
Original vault has 4 hardsuits, with this addition 9 suits in total. Vault items rarely see any use if at all, but by gameplay-wise players shouldn't have access to this many hardsuits without the aid of a machinist imo 
Currently all of these are a structure, fastened to the ground. I really like idea that engineers keep spare signs, but right now it's a bit weird having to unfasten them to pick them up. About its item types... Currently how they work is when a sign is unfastened, it'll transit from structure to base type item by caching its icon_state- so there's no explict types for each signs, which is pain 
An ideal room should make a good use of the space allocated for it, preferably without obstructing the foot traffic (especially if it's a junction part between rooms or a hallway). Currently this room feels empty and could use more detailing to make it look more alive and natural. In this case, this is a walkway between many important rooms in engineering, think of how workers would evaluate this space without getting awarded a talk in HR. Shrinking the size and giving the new space to the maintenance is also an option if detailing doesn't work well 
In this design science feels a bit burried with this rather secluded entrance. I think you can just add another hallway like this, or any other way you see fit 
Ditto with space usage here. You could carry or expand the connector section of atmos to here, or anything else you see fit 
Evaluate this space too please 
Please make sure to use hidden type here for the supply pipes 
You can put a line of lattices here like this to allow passage, unless you want to avoid that which is fine! |
|
Not an addition to above but just my thoughts, I think we should reserve the usage of dark tiles for the high-secure/important areas, or at least retain the usage of gray tiles in hallways. Colour choice is a good way to notify people about the theme of a room, and dark tiles are screaming "you're entering a serious place, watch your step!" |
|
Kano you rock TY. Also damn I never even thought of being able to hide everything but pipe/cable layers to check for that kind of crap. Will fix up the dumb errors that are the product of burnt out brain then work on the suggested revisions. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
|
|
!review |
|
A few things I missed during review: 
Excess pipes 
Disconnected grid 
Ditto 
Rogue cables 
Platform with wrong direction 
Rebel door 
Rogue request console 
Turbine room is kind of dark at the moment 
Science hallway needs some lighting as well |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
|
Made the acknowledged changes, and ran through view filters to clean up a good number more unlinked connections, rogue area assignments, misaligned fire doors, etc. |
|
!review |
3 participants
Overview:
The first huge fuckoff mapping PR for giving the Horizon enough extra space to be able to comfortably map on it for the duration before NBT2 and not be super cramped (extends aft by 6 turfs).
Includes a SECOND vault to heist at the back of the ship and a lot of maint area people can repurpose. Notably, this also removes the Xenobio Hazardous Containment room and the Medical Emergency Storage room (contents of the latter have been moved). Otherwise, y'all got more ship.
Map Images:
Misc Features:
