-
Notifications
You must be signed in to change notification settings - Fork 551
Persistent dirt #21381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FabianK3
wants to merge
34
commits into
Aurorastation:master
Choose a base branch
from
FabianK3:persistent-dirt
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Persistent dirt #21381
+250
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!wip |
…requires_canon_round
… floor damage cleanable types
|
Content scope freeze, testing. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. Mark the PR as ready for review again if it is ready to be reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🗺️ Mapping - Horizon
The PR touches the Horizon map files.
WIP
The PR is a work in progress and should not be reviewed yet.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds persistent dirt.
Details
Persistent dirt (cleanable tiles) types can be found up to 7 days.
In that regard all types are equal except: Blood, fuel and floor damage will not be persistent in non-canon rounds (gamemode != extended or odyssey != canon) and instead turn into dirt.
The same areal restrictions for persistent dirt exist as for persistent trash (maints).
The following types are planned:
Tasks
Thanks to @Arrow768 for starting with persistent dirt while I was still writing the subsystem and persistent trash.