add pintrl common files #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this unit testable or it relies on other libs? |
This is used to program SCU registers to enable certain functions. It needs to be tested with corresponding modules that it enabled. |
|
@rusty1968 This unit is to set/clear the SCU pinctrl bits, which is not depending on other libs for that matter. It can be tested to see if it sets/clears the correct bits. |
|
@rusty1968 Other libs depend on this module to set/clear their corresponding pinmux, so we need this to be reviewed and push first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a common pinctrl file.
Can set/clear more multi-function pinctrl bits in this file.