add matroos integration #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the REGIS url is not working anymore. Locally it does work and nlmod uses the same URL. Hopefully some temporary glitch. |
dbrakenhoff
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
Looks good! Anything avoiding waterinfo is worth its weight in gold 😀 !
No real remarks, only the names of the two helper functions might be improved, but I can't think of better ones at the moment.
- select_by_params --> select_timeseries_by_parameters?
- get_loc_source_units --> get_stations? get_location_overview?
I dunno, as I said, not sure how to improve the names, so I leave it up to you whether these names are sufficiently descriptive or you want to change them :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For waterlevel observations from RWS