fix: missed ref_doc_id in retrieval #1025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
@mystdeim is attempting to deploy a commit to the Arize Team on Vercel. A member of the Team first needs to authorize it. |
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
OK I now understand the issue. Thank you for bringing this to our attention. Let me discuss it with the team first, and follow up with you afterwards. |
codefromthecrypt
pushed a commit
to codefromthecrypt/openinference
that referenced
this pull request
Sep 15, 2025
**Description** we should trigger a reconciler after bsps are observed by the secret controller. **Related Issues/PRs (if applicable)** Fixes Arize-ai#1025 Signed-off-by: carlory <[email protected]>
|
Apologies from us that this never made it in. I think we never fully resolved this. Is it still something of interest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DOCUMENT_IDis actuallynode.node_idnow.It's difficult to track documents which are found by retrieval stage.
I suggest adding
ref_doc_idin the attributes.