Skip to content

Fix Custom RTD Bug #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Custom RTD Bug #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions LTC298X.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,7 @@ bool LTC298X::setupCustomRTD(uint8_t ch, uint8_t sr_ch, uint8_t wires, uint8_t m
//ROM for custom data is only 384 byte wide, so we can store a max of 64 2x3 byte pairs
start_addr_offset + num_values > 63
) return false; //invalid
uint16_t start_addr_offset_bytes = start_addr_offset * 6;
double old_ohm = 0;
double old_kelvin = 0;
for (uint8_t i = 0; i < num_values; i++) {
Expand All @@ -364,9 +365,9 @@ bool LTC298X::setupCustomRTD(uint8_t ch, uint8_t sr_ch, uint8_t wires, uint8_t m
if (kelvin[i] <= old_kelvin) return false; //must be greater
if (kelvin[i] >= 8192) return false; //must be less
//Resistance is absolute, so unsigned, saved as 13,11 unsigned fixed point fraction
write24(LTC298X_ADDR_RAM_START + start_addr_offset + i * 6, (uint32_t)(ohm[i] * 2048));
write24(LTC298X_ADDR_RAM_START + start_addr_offset_bytes + i * 6, (uint32_t)(ohm[i] * 2048));
//Kelvin is absolute, so unsinged, saved as 14,10 fixed point fraction
write24(LTC298X_ADDR_RAM_START + start_addr_offset + i * 6 + 3, (uint32_t)(kelvin[i] * 1024));
write24(LTC298X_ADDR_RAM_START + start_addr_offset_bytes + i * 6 + 3, (uint32_t)(kelvin[i] * 1024));
old_ohm = ohm[i];
old_kelvin = kelvin[i];
}
Expand Down