CVCotM: Un-bork the Advance Collection ROM #5132
Open
+16
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
waiting-on: peer-review
qwint
added
the
is: bug/fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
It turned out the Castlevania Advance Collection ROM wasn't working due to the fact that the start inventory hack was overlapping a hack that M2 inserted in the same spot as it in the AC ROM. This fixes support for it by relocating all the start inventory stuff completely (from starting at offset 0x680000 in the ROM to starting at 0x690000).
Note: this does NOT fix the audio-related problems that the AC ROM has. That occurs due to it missing its audio-related code.
How was this tested?
Generated and patched a game with a start inventory using both the cartridge and Advance Collection ROMs and verified both were working and both had the proper start inventory.