Pokemon RB: Add options to keep Poke Doll and Bicycle skips but not consider them in logic

[gerbiljames]

@palex00 Asked me to PR this.

What is this fixing or adding?

This adds options to keep the Poke Doll and Bicycle skips in the game, but not consider them in logic

How was this tested?

Ran some debug generations, and ensured the correct code paths were followed for patching/not patching the skips.

If this makes graphical changes, please attach screenshots.

N/A

[ScipioWright]

@Alchav

[palex00]

I half jokingly suggested it but I think it'd be a cool setting. Depends on if Alchav wants it as a setting. It kind of mimicks the flash thing (with it being allowed out of logic) so that's where my thinking comes from

[Exempt-Medic]

https://discord.com/channels/731205301247803413/1043592720603693167/1374158685953327194
Q. have a setting to have bike & doll skip not patched but also not in logic
A. Having an option to allow those skips to be done and in logic was the compromise, I would rather have just fixed them. They aren't like logic skips in ALTTP that require skills. They are like if instead of a guy checking for your badge requirement at the elite four, he was standing off to the side saying "please don't go past unless you have X badges."

That could have changed now though 🤷

[palex00]

https://discord.com/channels/731205301247803413/1043592720603693167/1374158685953327194 Q. have a setting to have bike & doll skip not patched but also not in logic A. Having an option to allow those skips to be done and in logic was the compromise, I would rather have just fixed them. They aren't like logic skips in ALTTP that require skills. They are like if instead of a guy checking for your badge requirement at the elite four, he was standing off to the side saying "please don't go past unless you have X badges."

That could have changed now though 🤷

In my defense, I 100% forgot about this already. Thanks for bringing it up though.